Cannot remove modules from state. Error: leftover module

[deobieta]

Terraform Version

Terraform v0.12.19

Terraform Configuration Files

provider "aws" {
  region = "us-east-1"
}

data "aws_vpc" "default" {
  default = true
}

module "security_group_example_http" {
  source = "terraform-aws-modules/security-group/aws//modules/http-80"
  name        = "web-server"
  version = "3.3.0"
  vpc_id      = data.aws_vpc.default.id
  ingress_cidr_blocks = ["0.0.0.0/0"]
}

Debug Output

Crash Output

Expected Behavior

Terraform should delete module resources and remove them from state.

Actual Behavior

Terraform deletes the resources but leaves the state file with information about the deleted modules. This causes CI systems to break.

Error: leftover module module.security_group_example_http.module.sg in state that should have been removed; this is a bug in Terraform and should be reported

Steps to Reproduce

1. terraform init
2. terraform apply
3. Remove module security_group_example_http
4. terraform apply

Additional Context

I did the same steps using version v0.12.18 and it works as expected.

References

The issue #22579 states that "-target" should be used in the "apply" to reproduce but it seems that it's a bigger problem now.

[deobieta]

If you run into this problem you can fix manually the state file following this steps:

1. terraform state pull > pulled-tfstate.json
2. Edit pulled-tfstate.json, delete all references to the deleted modules and increment serial number
3. terraform state push pulled-tfstate.json

[dghubble]

I've started seeing this in any workspace that upgrades to Terraform v0.12.19 :S

[dghubble]

#23822 appears to fix this issue (haven't verified myself) and was merged after v0.12.19, so I imagine it will appear in v0.12.20.

[hashibot]

Hello! 🤖

Duplicate of #23821

[deobieta]

#23822 appears to fix this issue (haven't verified myself) and was merged after v0.12.19, so I imagine it will appear in v0.12.20.

Thanks @dghubble

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.