Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/mq_broker - make maint window updatable + sweeper changes #24385

Merged
merged 4 commits into from
Apr 25, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Apr 24, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20241
Closes #19067
Closes #18365

Output from acceptance testing:

$ make testacc TESTS=TestAccMQBroker_AllFields_customVPC PKG=mq
--- PASS: TestAccMQBroker_AllFields_customVPC (1791.06s)

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. service/mq Issues and PRs that pertain to the mq service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Apr 24, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 24, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. and removed documentation Introduces or discusses updates to documentation. labels Apr 24, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review April 24, 2022 22:10
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make sweep SWEEPARGS=-sweep-run=aws_mq_broker SWEEP=us-west-2
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2 -sweep-run=aws_mq_broker -timeout 60m
2022/04/25 08:18:38 [DEBUG] Running Sweepers for region (us-west-2):
2022/04/25 08:18:38 [DEBUG] Running Sweeper (aws_mq_broker) in region (us-west-2)
2022/04/25 08:18:38 [INFO] Retrieved credentials from "EnvConfigCredentials"
2022/04/25 08:18:38 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/04/25 08:18:39 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/04/25 08:18:41 [DEBUG] Completed Sweeper (aws_mq_broker) in region (us-west-2) in 2.627689776s
2022/04/25 08:18:41 Completed Sweepers for region (us-west-2) in 2.627865921s
2022/04/25 08:18:41 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_mq_broker
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	6.163s
% make testacc TESTARGS='-run=TestAccMQBroker_AllFields_customVPC\|TestAccMQBroker_basic' PKG=mq ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mq/... -v -count 1 -parallel 2  -run=TestAccMQBroker_AllFields_customVPC\|TestAccMQBroker_basic -timeout 180m
=== RUN   TestAccMQBroker_basic
=== PAUSE TestAccMQBroker_basic
=== RUN   TestAccMQBroker_AllFields_customVPC
=== PAUSE TestAccMQBroker_AllFields_customVPC
=== CONT  TestAccMQBroker_basic
=== CONT  TestAccMQBroker_AllFields_customVPC
--- PASS: TestAccMQBroker_basic (960.22s)
--- PASS: TestAccMQBroker_AllFields_customVPC (1744.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mq	1748.107s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ec18033 into hashicorp:main Apr 25, 2022
@github-actions github-actions bot added this to the v4.12.0 milestone Apr 25, 2022
@github-actions
Copy link

This functionality has been released in v4.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the mq-broker-update-maint branch May 21, 2022 12:44
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/mq Issues and PRs that pertain to the mq service. size/M Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants