Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sweepers/aws_mq_broker: Should use paginated function #18365

Closed
gdavison opened this issue Mar 24, 2021 · 2 comments · Fixed by #24385
Closed

sweepers/aws_mq_broker: Should use paginated function #18365

gdavison opened this issue Mar 24, 2021 · 2 comments · Fixed by #24385
Labels
service/mq Issues and PRs that pertain to the mq service. sweeper Pertains to changes to or issues with the sweeper. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone
v4.12.0

Comments

@gdavison
Copy link
Contributor

The sweeper for aws_mq_broker does not use a paginated call to list all MQ Brokers. It should.
@gdavison gdavison added technical-debt Addresses areas of the codebase that need refactoring or redesign. service/mq Issues and PRs that pertain to the mq service. labels Mar 24, 2021
@anGie44 anGie44 self-assigned this Jun 18, 2021
@anGie44 anGie44 removed their assignment Jul 19, 2021
@DrFaust92 DrFaust92 added the sweeper Pertains to changes to or issues with the sweeper. label Apr 24, 2022
@DrFaust92 DrFaust92 self-assigned this Apr 24, 2022
DrFaust92 added a commit to DrFaust92/terraform-provider-aws that referenced this issue Apr 24, 2022
@DrFaust92
Fix hashicorp#18365 and hashicorp#19067
5277964
@DrFaust92 DrFaust92 mentioned this issue Apr 24, 2022
Merged
@github-actions github-actions bot added this to the v4.12.0 milestone Apr 25, 2022
@DrFaust92 DrFaust92 removed their assignment Apr 25, 2022
@github-actions
Copy link

This functionality has been released in v4.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
service/mq Issues and PRs that pertain to the mq service. sweeper Pertains to changes to or issues with the sweeper. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v4.12.0
Development

Successfully merging a pull request may close this issue.

r/mq_broker - make maint window updatable + sweeper changes DrFaust92/terraform-provider-aws
3 participants
@gdavison @anGie44 @DrFaust92