Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds client_config_options to aws_ec2_client_vpn_endpoint #16056 #18916

Conversation

LarsFronius
Copy link
Contributor

This implements client connection handlers for AWS Client VPN endpoints to fix #16056

@LarsFronius LarsFronius requested a review from a team as a code owner April 16, 2021 14:14
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 16, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 16, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @LarsFronius 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@LarsFronius LarsFronius force-pushed the add-client-vpn-client-config-options branch from c02483e to 820d192 Compare April 16, 2021 14:29
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Apr 16, 2021
@LarsFronius LarsFronius force-pushed the add-client-vpn-client-config-options branch from 138022a to 3be9410 Compare April 16, 2021 14:58
@LarsFronius LarsFronius force-pushed the add-client-vpn-client-config-options branch from 3be9410 to 8f9c297 Compare April 16, 2021 15:01
@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Apr 17, 2021
@YakDriver
Copy link
Member

@LarsFronius Thanks for this submission! Please add a changelog file. Also, if you can provide the results of running acceptance tests, that would be great. Thank you!

@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@ewbankkit
Copy link
Contributor

Superseded by #22793.

@ewbankkit
Copy link
Contributor

@LarsFronius Thanks for the contribution 🎉 👏.
I have incorporated your changes into #22793.

@ewbankkit ewbankkit closed this Jan 31, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client Connection Handler for Client VPN Endpoint
4 participants