Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Connection Handler for Client VPN Endpoint #16056

Closed
KyleKotowick opened this issue Nov 5, 2020 · 5 comments · Fixed by #22793
Closed

Client Connection Handler for Client VPN Endpoint #16056

KyleKotowick opened this issue Nov 5, 2020 · 5 comments · Fixed by #22793
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@KyleKotowick
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS Client VPN Endpoints support a featured called "Client Connection Handler", which is a Lambda function that dynamically determines if a client should be allowed to connect or not. Currently, the Terraform AWS provider does not have any configuration option to support this feature.

New or Affected Resource(s)

  • aws_ec2_client_vpn_endpoint

Potential Terraform Configuration

aws_ec2_client_vpn_endpoint "client_vpn" {
  ... existing config options
  client_connect_handler_arn = aws_lambda_function.vpn_connection_handler.arn
}

Note that there are a couple restrictions on the Lambda that would be good to check. Namely, its name must start with the prefix "AWSClientVPN-" and it must have a timeout of 30 seconds.

@KyleKotowick KyleKotowick added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 5, 2020
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Nov 5, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 5, 2020
@ewbankkit
Copy link
Contributor

ewbankkit commented Nov 5, 2020

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Nov 5, 2020
@ewbankkit
Copy link
Contributor

ewbankkit commented Nov 5, 2020

Strictly speaking the new syntax should be

aws_ec2_client_vpn_endpoint "example" {
  client_connect_options {
    enabled = true

    lambda_function_arn = aws_lambda_function.example.arn
  }
}

to match the AWS API.

@choeflake
Copy link

Hi, could this issue get some prio?

ewbankkit added a commit to thiagokiyota/terraform-provider-aws that referenced this issue Jan 28, 2022
@github-actions github-actions bot added this to the v3.75.0 milestone Jan 31, 2022
@ewbankkit ewbankkit modified the milestones: v3.75.0, v4.0.0 Feb 1, 2022
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
3 participants