grpclb: do not send redundant empty load reports to remote LB #3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small refactor of tests: - Add a channel to remoteBalancer on which to send received stats messages - Change runAndGetStats to runAndCheckStats to allow for faster successful test runs (no longer need to sleep for one whole second per test). - Remove redundant leak check from runAndCheckStats, otherwise excess load report messages not read from the channel will result in an infinite loop.
menghanl
suggested changes
Dec 12, 2019
| @@ -49,6 +49,14 @@ func newRPCStats() *rpcStats { | |||
| } | |||
| } | |||
|
|
|||
| func isZeroStats(stats *lbpb.ClientStats) bool { | |||
| return len(stats.CallsFinishedWithDrop) == 0 && | |||
There was a problem hiding this comment.
All fields need to be accessed atomically
There was a problem hiding this comment.
These are in the stats message, not in the rpcStats struct.
dfawley
force-pushed
the
grpclb_quash
branch
from
18407dc
to
b9945f4
Compare
menghanl
approved these changes
Dec 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor of tests:
runs (no longer need to sleep for one whole second per test).
report messages not read from the channel will result in an infinite loop.