lock during checkStats to avoid race if stats are updated while checking

grpc · Dec 12, 2019 · b9945f4 · b9945f4
1 parent 4fef929
commit b9945f4
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/balancer/grpclb/grpclb_test.go b/balancer/grpclb/grpclb_test.go
@@ -1108,6 +1108,10 @@ func (failPreRPCCred) RequireTransportSecurity() bool {
 
 func checkStats(stats, expected *rpcStats) error {
 	if !stats.equal(expected) {
+		stats.mu.Lock()
+		defer stats.mu.Unlock()
+		expected.mu.Lock()
+		defer expected.mu.Unlock()
 		return fmt.Errorf("stats not equal: got %+v, want %+v", stats, expected)
 	}
 	return nil