Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup usages of resolver.Target.Authority #5795

Closed
easwars opened this issue Nov 15, 2022 · 2 comments · Fixed by #6363
Closed

Cleanup usages of resolver.Target.Authority #5795

easwars opened this issue Nov 15, 2022 · 2 comments · Fixed by #6363
Assignees
@ginayeh
Labels
fixit P2 Type: Bug

Comments

@easwars
Copy link
Contributor

easwars commented Nov 15, 2022

resolver.Target.Authority is marked as deprecated, and we added resolver.Target.URL which is the more preferred way of getting to the details of the parsed target.

Codebase needs to be inspected for usages of resolver.Target.Authority and replaced with resolver.Target.URL.Host.
@zasweq zasweq added the fixit label Nov 28, 2022
@ramil600
Copy link

I worked on cleaning up some tests: submitted PR #5858

@kylejb kylejb mentioned this issue Dec 15, 2022
Closed
@ginayeh
Copy link
Contributor

ginayeh commented Jun 2, 2023

According to #5754, #5761 should close this issue, so marking this as closed.

@ginayeh ginayeh closed this as completed Jun 2, 2023
ginayeh added a commit to ginayeh/grpc-go that referenced this issue Jun 6, 2023
@ginayeh
Delete resolver.Target.Scheme and resolver.Target.Authority grpc#5795
713f86e
@ginayeh ginayeh reopened this Jun 6, 2023
@ginayeh ginayeh self-assigned this Jun 6, 2023
ginayeh added a commit that referenced this issue Jun 6, 2023
@ginayeh
Delete resolver.Target.Scheme and resolver.Target.Authority #5795
6d17902
@ginayeh ginayeh linked a pull request Jun 6, 2023 that will close this issue
resolver: delete Target.Scheme and Target.Authority #6353
Closed
ginayeh added a commit that referenced this issue Jun 6, 2023
@ginayeh
Delete resolver.Target.Scheme and resolver.Target.Authority #5795
7a28e98
@dfawley dfawley mentioned this issue Jun 6, 2023
Closed
@ginayeh ginayeh mentioned this issue Jun 8, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ginayeh ginayeh

Labels
fixit P2 Type: Bug
Projects
None yet
Milestone
No milestone
5 participants
@easwars @ginayeh @dfawley @zasweq @ramil600