Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup usages of resolver.Target.Scheme #5754

Closed
easwars opened this issue Nov 1, 2022 · 2 comments
Closed

Cleanup usages of resolver.Target.Scheme #5754

easwars opened this issue Nov 1, 2022 · 2 comments

Comments

@easwars
Copy link
Contributor

easwars commented Nov 1, 2022

resolver.Target.Scheme is marked as deprecated, and we added resolver.Target.URL which is the more preferred way of getting to the details of the parsed target.

#5750 is replacing usages of resolver.Target.Scheme in clientconn.go. But we have other usages spread across the codebase, and it would be a nice thing to clean those up as well.

@kylejb
Copy link
Contributor

kylejb commented Dec 15, 2022

Does #5761 close this issue and cleanup usages of resolver.Target.Authority?

The only bits where we seem to use resolver.Target.Scheme that I found is here and here. Do we want to remove those lines or continue to set usable values to the deprecated resolver.Target.Scheme?

@easwars
Copy link
Contributor Author

easwars commented Dec 15, 2022

Yes, it does close this issue. And the two bits you pointed to, we can continue to have them. Thank you @kylejb .

@easwars easwars closed this as completed Dec 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants