Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit "whole-only" config families to "growing" and "every nvt" #1386

Merged
merged 11 commits into from
Jan 13, 2021

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Dec 22, 2020

What:

This brings gvmd in line with the interface change from greenbone/gsa#2222:

  • prevent selection/exclusion of single NVTs with certain LSC families
  • prevent static selection of certain LSC families
  • after every NVT sync ensure that certain LSC families stay "entire family, growing"

Why:

For certain LSC families GSA only allows selection of the entire family in configs. gvmd should match this

  • for consistency
  • to avoid confusion and errors resulting from gvmd offering different capabilities from GSA via GMP
  • to make it easy for openvas-ospd to select the driver NVT for these families (if the only case is selecting entire growing family, then ospd-openvas only needs to match the vt_group for the family).

How did you test it:

GMP that should fail:

  • <modify_config config_id="49b2cb3b-79ea-4093-bee3-8bce68797484"><nvt_selection><family>CentOS Local Security Checks</family><nvt oid="1.3.6.1.4.1.25623.1.0.880021"/></nvt_selection></modify_config>
  • <modify_config config_id="dea76e26-0fca-4628-9476-af8e521a475c"><family_selection><growing>1</growing><family><name>Debian Local Security Checks</name><all>1</all></family></family_selection></modify_config>
  • <modify_config config_id="49b2cb3b-79ea-4093-bee3-8bce68797484"><nvt_selection><family>CentOS Local Security Checks</family><nvt oid="1.3.6.1.4.1.25623.1.0.880021"/></nvt_selection></modify_config>

GMP that should pass:

  • <modify_config config_id="dea76e26-0fca-4628-9476-af8e521a475c"><family_selection><growing>1</growing><family><name>Debian Local Security Checks</name><all>0</all></family></family_selection></modify_config>
  • <modify_config config_id="dea76e26-0fca-4628-9476-af8e521a475c"><nvt_selection><family>Port scanners</family><nvt oid="1.3.6.1.4.1.25623.1.0.14259"/></nvt_selection></modify_config>

Checklist:

@mattmundell mattmundell marked this pull request as ready for review December 23, 2020 14:56
@timopollmeier timopollmeier merged commit 1f9aacd into greenbone:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants