Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some Families selectable as a whole only #2222

Merged
merged 5 commits into from
Jun 30, 2020

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented Jun 9, 2020

Several NVT families are now selectable as a whole only.
The trend is always set to dynamic, static is disabled, and the Edit Icon previously used to select individual NVTs is removed.

Checklist:

@swaterkamp swaterkamp self-assigned this Jun 9, 2020
@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #2222 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2222      +/-   ##
==========================================
+ Coverage   52.75%   52.76%   +0.01%     
==========================================
  Files        1070     1070              
  Lines       25783    25790       +7     
  Branches     7307     7311       +4     
==========================================
+ Hits        13601    13608       +7     
  Misses      11060    11060              
  Partials     1122     1122              
Impacted Files Coverage Δ
gsa/src/web/pages/scanconfigs/nvtfamilies.js 92.85% <100.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a3bbc...20797cc. Read the comment docs.

@swaterkamp swaterkamp marked this pull request as ready for review June 29, 2020 14:51
@swaterkamp swaterkamp requested a review from a team June 29, 2020 14:51
@bjoernricks bjoernricks merged commit d4f044e into greenbone:master Jun 30, 2020
@swaterkamp swaterkamp deleted the wholeFamilySelection branch April 20, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants