-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render administrative boundary text labels for relations only #3762
Render administrative boundary text labels for relations only #3762
Conversation
Currently lines are only rendered for borders mapped as relations (i.e. osm_id <0) but the text labels along the borders are rendered for relations and closed ways. This commit adds a filter for "AND osm_id < 0" to the admin-text layer, so that the text labels do not appear in the rare occasions when an administrative boundary is mapped as a closed way instead of a relation
Is anyone available to review this PR? I would like to submit other improvements to the administrative boundaries, but I can't until this one is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Also fixes #2663.
It also turns #713 into a declined request. I edited top post to fix https://www.openstreetmap.org/way/146660105/ link |
Just noticed this had not been merged yet, sorry for the delay. |
…ystorm#3762) * Render text labels along borders of admin boundary relations only Currently lines are only rendered for borders mapped as relations (i.e. osm_id <0) but the text labels along the borders are rendered for relations and closed ways. This commit adds a filter for "AND osm_id < 0" to the admin-text layer, so that the text labels do not appear in the rare occasions when an administrative boundary is mapped as a closed way instead of a relation * Render central name labels for country and province/state relations only
…ystorm#3762) * Render text labels along borders of admin boundary relations only Currently lines are only rendered for borders mapped as relations (i.e. osm_id <0) but the text labels along the borders are rendered for relations and closed ways. This commit adds a filter for "AND osm_id < 0" to the admin-text layer, so that the text labels do not appear in the rare occasions when an administrative boundary is mapped as a closed way instead of a relation * Render central name labels for country and province/state relations only
Fixes #3761 and Fixes #2663
Changes proposed in this pull request:
Explanation:
osm_id < 0
)place=island
orlanduse=residential
.Test renderings:
Keaukaha Hawaiian Homeland, Hawaii USA
https://www.openstreetmap.org/way/146660105/
z16 Before
After
Ilheus Das Cabras, Azores, Portugal
https://www.openstreetmap.org/way/157531901/
natural=coastline
+place=islet
+name=Ilheus das Cabras
+boundary=administrative
+admin_level=4
(the administrative boundary of the Azores province follows the coastline)type=boundary
which has this way as a member.z16 Before
After
z18 Before
After