Render administrative boundary text labels for relations only #3762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently lines are only rendered for borders mapped as relations (i.e. osm_id <0) but the text labels along the borders are rendered for relations and closed ways. This commit adds a filter for "AND osm_id < 0" to the admin-text layer, so that the text labels do not appear in the rare occasions when an administrative boundary is mapped as a closed way instead of a relation
|
Is anyone available to review this PR? I would like to submit other improvements to the administrative boundaries, but I can't until this one is merged. |
|
It also turns #713 into a declined request. I edited top post to fix https://www.openstreetmap.org/way/146660105/ link |
|
Just noticed this had not been merged yet, sorry for the delay. |
sommerluk
pushed a commit
to sommerluk/openstreetmap-carto
that referenced
this pull request
Aug 5, 2019
…ystorm#3762) * Render text labels along borders of admin boundary relations only Currently lines are only rendered for borders mapped as relations (i.e. osm_id <0) but the text labels along the borders are rendered for relations and closed ways. This commit adds a filter for "AND osm_id < 0" to the admin-text layer, so that the text labels do not appear in the rare occasions when an administrative boundary is mapped as a closed way instead of a relation * Render central name labels for country and province/state relations only
sommerluk
pushed a commit
to sommerluk/openstreetmap-carto
that referenced
this pull request
Aug 5, 2019
…ystorm#3762) * Render text labels along borders of admin boundary relations only Currently lines are only rendered for borders mapped as relations (i.e. osm_id <0) but the text labels along the borders are rendered for relations and closed ways. This commit adds a filter for "AND osm_id < 0" to the admin-text layer, so that the text labels do not appear in the rare occasions when an administrative boundary is mapped as a closed way instead of a relation * Render central name labels for country and province/state relations only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3761 and Fixes #2663
Changes proposed in this pull request:
Explanation:
osm_id < 0)place=islandorlanduse=residential.Test renderings:
Keaukaha Hawaiian Homeland, Hawaii USA
https://www.openstreetmap.org/way/146660105/
z16 Before
After
Ilheus Das Cabras, Azores, Portugal
https://www.openstreetmap.org/way/157531901/
natural=coastline+place=islet+name=Ilheus das Cabras+boundary=administrative+admin_level=4(the administrative boundary of the Azores province follows the coastline)type=boundarywhich has this way as a member.z16 Before
After
z18 Before
After