Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Administrative boundaries not being rendered for closed ways #713

Closed
matthijsmelissen opened this issue Jul 10, 2014 · 4 comments
Closed

Comments

@matthijsmelissen
Copy link
Collaborator

See here for an example:

http://www.openstreetmap.org/?lat=37.88179412484169&lon=-122.3072612285614&zoom=18

The way representing the boundary for the city of Albany, which is being rendered by Mapnik, has a small gap, while the adjacent city of Berkeley boundary is closed. When I close the gap, Albany's borders disappear from the map. It appears that non-closed ways and closed ways that are part of relations are being rendered, but closed ways without relations are not.

See https://trac.openstreetmap.org/ticket/4667.

@matkoniecz
Copy link
Contributor

the same happens with man_made=embankment - see http://help.openstreetmap.org/questions/35020/how-should-i-map-this-artificial-hill/35023 and example at http://www.openstreetmap.org/#map=19/52.29455/5.08556

http://www.openstreetmap.org/way/235003112 is not displayed, http://www.openstreetmap.org/way/234838596 is (235003112 also was displayed before my change)

@mverwijmeren
Copy link

I do not think this is one bug. Look at the following three lines from openstreetmap-carto.style:

node,way admin_level text linear
node,way boundary text linear
node,way man_made text polygon

For the boundaries the question is: "Why don't closed boundary ways end up in the planet_osm_roads table?". So this is actually an OSM2PgSQL problem.

For the embankments it is obvious why (and correct that) they end up in two tables. It just needs a UNION query on line 587 of project.mml (cliffs layer) to fix this.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Dec 1, 2018

Looks like it's working now.

@jeisenbe
Copy link
Collaborator

Should we stop rendering the border lines from unclosed ways (lines)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants