Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Administrative boundary tagging on closed ways #2663

Closed
imagico opened this issue Jun 25, 2017 · 0 comments · Fixed by #3762
Closed

Administrative boundary tagging on closed ways #2663

imagico opened this issue Jun 25, 2017 · 0 comments · Fixed by #3762

Comments

@imagico
Copy link
Collaborator

imagico commented Jun 25, 2017

I was inspecting the changes in rendering due to fixing #59 a bit further and wonder if we correctly interpret boundary tags on closed ways. I am in particular thinking about cases like

http://www.openstreetmap.org/way/162691988

and

http://www.openstreetmap.org/way/10364857

We interpret these as administrative unit areas (see the labels) and not just as administrative boundary lines although the mapper clearly intended the administrative boundary tagging to apply to the line and the name tag only to the place=island - and as i interpret them tagging conventions say that administrative units have to be boundary relations and ways with boundary tags are always just boundary lines.

I know this kind of tagging is inherently ambiguous and should probably be avoided (by creating a multipolygon relation for the island) but IMO ideally we should require administrative unit areas to be boundary relations.

matthijsmelissen pushed a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Nov 20, 2017
This requires rendering admin boundaries based on the individual
lines, rather than the entire polygons.

* This fixes gravitystorm#621
* This possibly impacts solutions to gravitystorm#723, #2234m and gravitystorm#2663.
matthijsmelissen pushed a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Feb 5, 2018
This requires rendering admin boundaries based on the individual
lines, rather than the entire polygons.

* This fixes gravitystorm#621
* This possibly impacts solutions to gravitystorm#723, #2234m and gravitystorm#2663.
matthijsmelissen pushed a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Feb 16, 2018
This requires rendering admin boundaries based on the individual
lines, rather than the entire polygons.

* This fixes gravitystorm#621
* This possibly impacts solutions to gravitystorm#723, #2234m and gravitystorm#2663.
matthijsmelissen pushed a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 10, 2018
This requires rendering admin boundaries based on the individual
lines, rather than the entire polygons.

* This fixes gravitystorm#621
* This possibly impacts solutions to gravitystorm#723, #2234m and gravitystorm#2663.
matthijsmelissen pushed a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 10, 2018
This requires rendering admin boundaries based on the individual
lines, rather than the entire polygons.

* This fixes gravitystorm#621
* This possibly impacts solutions to gravitystorm#723, #2234m and gravitystorm#2663.
matthijsmelissen pushed a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Apr 12, 2018
This requires rendering admin boundaries based on the individual
lines, rather than the entire polygons.

* This fixes gravitystorm#621
* This possibly impacts solutions to gravitystorm#723, #2234m and gravitystorm#2663.
matthijsmelissen pushed a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Apr 12, 2018
This requires rendering admin boundaries based on the individual
lines, rather than the entire polygons.

* This fixes gravitystorm#621
* This possibly impacts solutions to gravitystorm#723, #2234m and gravitystorm#2663.
matthijsmelissen pushed a commit that referenced this issue May 8, 2018
This requires rendering admin boundaries based on the individual
lines, rather than the entire polygons.

* This fixes #621
* This possibly impacts solutions to #723, #2234m and #2663.
matthijsmelissen pushed a commit that referenced this issue May 8, 2018
This requires rendering admin boundaries based on the individual
lines, rather than the entire polygons.

* This fixes #621
* This possibly impacts solutions to #723, #2234m and #2663.
matthijsmelissen pushed a commit that referenced this issue May 8, 2018
This requires rendering admin boundaries based on the individual
lines, rather than the entire polygons.

* This fixes #621
* This possibly impacts solutions to #723, #2234m and #2663.
matthijsmelissen pushed a commit that referenced this issue May 8, 2018
This requires rendering admin boundaries based on the individual
lines, rather than the entire polygons.

* This fixes #621
* This possibly impacts solutions to #723, #2234m and #2663.
matthijsmelissen pushed a commit that referenced this issue May 8, 2018
This requires rendering admin boundaries based on the individual
lines, rather than the entire polygons.

* This fixes #621
* This possibly impacts solutions to #723, #2234m and #2663.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant