Clean up z13 #3467
Clean up z13 #3467
Conversation
|
Preview z13: After: |
matthijsmelissen
force-pushed
the
z13-cleanup
branch
2 times, most recently
from
a7c35fe
to
aa52f30
Compare
|
How about moving intermittent and seasonal streams down one zoom level but
leaving the regular streams as-is?
At any rate I think intermittent streams should be rendered one zoom level
later than year-round streams.
…On Sun, Oct 21, 2018 at 7:52 PM Matthijs Melissen ***@***.***> wrote:
Preview z13:
Before:
[image: screen shot 2018-10-21 at 12 51 03]
<https://user-images.githubusercontent.com/5251909/47265944-1444cd80-d530-11e8-9794-5290492548c3.png>
[image: screen shot 2018-10-21 at 12 51 55]
<https://user-images.githubusercontent.com/5251909/47265948-245cad00-d530-11e8-9153-76c6b3793e58.png>
Preview z14:
Before:
[image: screen shot 2018-10-21 at 12 50 15]
<https://user-images.githubusercontent.com/5251909/47265936-ef505a80-d52f-11e8-96cd-6067dd6c49e4.png>
After:
[image: screen shot 2018-10-21 at 12 49 28]
<https://user-images.githubusercontent.com/5251909/47265928-d9429a00-d52f-11e8-81e4-321fb9005da1.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3467 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshIeKD7WdigkyNK_q8Awji0RinxzQks5unFH1gaJpZM4XyZL8>
.
|
|
sent from a phone
On 21. Oct 2018, at 12:52, Matthijs Melissen ***@***.***> wrote:
Preview z13:
Before:
missing buildings are considerably worse than having them at z13. Look for instance at the bigger buildings, how the situation becomes misrepresented by appearing void without them.
Even without being able to discern every single small building, the sum of these create the morphology of the city (together with the roads), and this scale is interesting for seeing buildings and bigger urban structures and patterns.
In a bigger scheme, osm carto as a raster map is in the position of being able to show the buildings earlier than a vector map can (there is almost no cost in terms of tile size and no cost in terms of client rendering time, compared to vector tiles), and my stance is we should use this advantage, as an alternative for people interested in urban structures.
|
|
This seems to go against the first item at https://github.com/gravitystorm/openstreetmap-carto/blob/master/CARTOGRAPHY.md "an important feedback mechanism for mappers". Also providing examples only of a densly-populated Central European city will do nothing to placate critics who've accused this style as being targeted at those areas only in the past ... |
|
Honestly, no one is going to understand this change... Especially dropping buildings from z13/14 will be totally alien to our openstreetmap community and heavily contested if implemented. |
|
I will try to reply to the critics later (also look closer at all the proposed changes individually), for now just Warsaw example: z13 Before After z14 Before After |
|
It's good to look back to see how the database grows over the years creating more noise. Using current version of style (without this PR) for the last CC BY-SA licensed planet file (2012) and comparing with current data in Warsaw: z13, 2012
z13, 2018
z14, 2012
z14, 2018
|
|
This adds nothing new to the existing images. What it actually mainly shows IMO is the less than ideal choice of a highly saturated highway=footway color in openstreetmap-carto, which is the main cause of the clutter, and the addition of many sidewalks. Unfortunately, although your Polish fellow mappers have been very active adding such sidewalk detail, they have been far less diligent in adding additional tags like footway=sidewalk/crossing, that might help filter out this clutter at medium zooms like Z13/14. |
I think it doesn't. The key is that only some buildings are visible on midzoom, and they are related to some special areas, which are eclipsed by them. z13 is the first zoom level where people can have proper feedback about landuses that are medium-level structures. It also supports diversity and helps to see where they are omitted. This is related to #2896 - there's no single magical solution to show bigger entities/structures without eclipsing them with smaller features, since it would require considering very special relations (like "this park is part of the hospital, so render it one step later"), which is unlikely. However showing all the possible landuses without buildings on one zoom level at least gives the general impression what bigger areas are there before we go into details and loose this general view. Having said that, I think that one special zoom level for landuses is enough and I would not remove buildings from z14. |
matthijsmelissen
force-pushed
the
z13-cleanup
branch
from
aa52f30
to
16d0cf1
Compare
Good idea. I have removed intermittent streams/ditches/drains from z14 too now.
No, the opposite: the feedback mechanism for retail landuse is currently almost absent, this PR will improve this. Seeing the buildings one level later make not much difference in terms of feedback for building mappers.
I have checked other areas as well, but I'm not planning on making screenshots of every arbitrary place on earth. Anyone who is interested in how this change behaves in other areas can run the code for themselves (and I'm happy to hear about potential issues in other areas).
I have adapted this pull request to only drop buildings from z13 for now. |
|
@kocio-pl As far as I concerned this is ready to be merged now, what do you think? |
|
Some more examples of cleaning the noise on z13 and giving better feedback on landuses (thanks to @Komzpa I was able to import the whole Europe to check on his server): London
Moscow
Stockholm
Madrid
Barcelona
Athens
|
|
I'm not sure however about tram lines - it makes individual stops more visible, which makes more noise (dots instead of lines). |
|
Stockholm and Barcelona look odd in their medieval urban centers. Is this
because the streets are pedestrianized? The lack of landuse is also
apparent, but I understand that this should be added.
If we are going by a size rule, aren’t pedestrian streets equal in size to
residential streets?
…On Mon, Oct 29, 2018 at 8:20 AM kocio-pl ***@***.***> wrote:
I'm not sure however about tram lines - it makes individual stops more
visible, which makes more noise (dots instead of lines).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3467 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshHKpD3Zy7-M9oinzn3yZJqlcKXf9ks5upjvPgaJpZM4XyZL8>
.
|
|
Resolves part of #2629. |
Please note that this is not an official rule of the style, or a rule agreed on by the maintainers. |
Yes, I think so. Think of it this way: if an car driver is driving from north to south Stockholm, he should know that he should navigate around the city centre. |
|
Interesting take! I haven't thought about it this way, but it makes a lot of sense for me - medium scale is more about transportation than pedestrian-related objects. |
|
This PR changes the tram line color to #8E8E8E for zooms 13 and up, while it remains #6E6E6E at z12. Is it intentional that tram lines become lighter when zooming in from z12 to z13? |
|
sent from a phone
On 29. Oct 2018, at 01:08, Matthijs Melissen ***@***.***> wrote:
Please note that this is not an official rule of the style, or a rule agreed on by the maintainers.
it seemed to be the only or main argument for some changes that were introduced recently...
|
|
sent from a phone
On 29. Oct 2018, at 01:11, Matthijs Melissen ***@***.***> wrote:
Yes, I think so. Think of it this way: if an car driver is driving from north to south Stockholm, he should know that he should navigate around the city centre.
sounds like a hint from captain obvious ;-)
Does this change imply we are now focusing more on car drivers?
|
That's definitely something that very much depends on the user. Speaking personally, z13 is what I'd normally use for pedestrian route planning. Obviously (due to changes over a number of years, actually) the style is a bit rubbish for that already (compare for example https://map.atownsend.org.uk/maps/map/map.html#zoom=13&lat=54.0967&lon=-1.0322 , which considers pedestrian horse/cycle routes important to show, and https://www.openstreetmap.org/#map=13/54.0971/-1.0530 in the standard style, which seems to give visual priority to streams and ditches, and the national park and admin boundaries. |
I am almost certain this is going to lead to a barrage of complaints of our user base who are not involved in style development, and won't understand this change. So unless you are "ready" to deal with that, and possibly have to revert this change ASAP if the masses arrive here on the Github repository or in the forums to complain, I don't think you are ready yet to implement this. |
|
Oh noooooooooo! Please bring back the buildings! Look how strange the yellow and purple areas look without them (clinics, schools, other big buildings). Z13: Akward "empty" areas Z14: Ahhhhhhh... now I understand the map |
|
This was done month ago. They look great to me, this zoom level is clear now, especially after moving tram and subway stations to z14+ in some bigger cities in the latest release. The visual noise is smaller. |
I disagree and share @dieterdreist 's optinion:
My opinion is the one of a confused mapper that though that there was a bug. Please treat this seriously. |
There's nothing strange about someone going "oh look a retail area" and then zooming in one more level see the buildings if they want. Its already done at z12 to z13 to see specific landuse. Or is that strange also? Hopefully this help people micro map landuse more now that it has its own zoom level at least. Instead of mapping whole towns as residential like they normally do. |
I do really treat it very seriously, believe me. It's always bugging me when someone has a problem with this style, since I'd like it to be good for all the people if possible. But it's not possible and I just have different view on z13 buildings problem than you. For me this is natural progression of the urban structure:
Using intermediate step between what is shown on z12 and z14 is a nice idea for me. Smooth changes of details level is what I like. |
|
Hi @kocio-pl, Looking at provided screenshot I tend to read what was clear "University" previously as "A large field or maybe parking". Ways of mitigating this that I see:
|
|
Both need some testing to make sure how it works. However I don't believe in easy finding new university color (see the problems we have with #3544), so maybe would you like to prepare code implementing second idea? I guess this might be harder than you expect, but why not try. |
|
Relevant code in Belroad: I can blindly adapt openstreetmap-carto to match it, I don't have any map rendering setup at hand now to test. |
|
You could use this to test: https://github.com/gravitystorm/openstreetmap-carto/blob/master/DOCKER.md |
|
@kocio-pl : I do agree that cleaning z13 is a good idea. But I do think that simply leaving out the buildings was not a good thing to do. @Komzpa 's idea looks like a good approach to clean z13 but still maintaining the relevant structures. My vote is to undo this change until an improved version is found for buildings. |
|
Maybe it could be improved once the major/minor building thing is implimented or a similar solution is found like rendering based on building type. IMHO though a regression based on the negitive opinions of a few people that dont like how its rendered wouldnt be a good idea. As it not an actual bug/problem. So it should be treated like every other rendering improvement where a solution is found instead. Plenty of things that could look better in a few instances wait for solutions. Theres no reason this issue shouldnt be any different. Its not really that drastically bad. Plus, it did sit there for like a month without serious critism and recived the thumbs up from multiple people before it was merged. So... |
|
@Adamant36 : I completely agree with you that there are many other issues but I definitely think this should be treated differently. Not having any opposing votes in this repository is not an indicator that people mostly think that this is a good change. I didn't read about this in here even if I do contribute here from time to time. I came here because I was confused. And I do think that many other people are, too but don't know where to address their confusion. It's easy to get in a trap when you're the developer and then live in a bubble where everything makes perfect sense. And you can, indeed, explain why this is a good idea. But almost nobody knows about those ideas behind it and is left behind alone with it's confusion. We should definitively revert that change and re-release it once it's done right. |
|
Problems such those underlined by @Komzpa happen with large areas without a great density of road or large buildings. Inversely, if you consider dense area with important road network such as some capitals (Paris, London or Berlin, I have also tried with Geneva), the removal of buildings is beneficial and you can even better identify some specific areas ( |
|
In general it is better to open a new issue rather than start commenting in old. This discussion may easily end forgotten unlike new issue that would need to be explicitly closed.
Note that we are not voting. Single comment with a new argument should have weight greater than 100 +1 comments. |
|
It sounds like one new issue might be that the new societal_amenities
rendering (light yellow for schools and hospitals) is too light. Is that
correct?
@Adamant36 recently mentioned that he would have preferred more time to
perfect this color. A slightly darker and more saturated shade of yellow
might help.
…On Mon, Dec 24, 2018 at 1:34 AM Mateusz Konieczny ***@***.***> wrote:
In general it is better to open a new issue rather than start commenting
in old.
This discussion may easily end forgotten unlike new issue that would need
to be explicitly closed.
------------------------------
My vote is to
Note that we are not voting. Single comment with a new argument should
have weight greater than 100 +1 comments.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3467 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshJWhGVg4pYMDUw2BUW7_X4xSUsLJks5u77B6gaJpZM4XyZL8>
.
|
This pull request cleans up the rendering on z13 and z14, by removing a number of features from these zoom levels.
and z14Fixes #3331.
The primary purpose of this pull request is to remove visual clutter from z13 and z14. These zoom levels contain lots of tiny elements that are hard to interpret, and lead to noise in the images. As a consequence of removing these features, the remaining features (such as the street pattern) become easier to read.
The secondary purpose is to give more attention to landuse rendering on these zoom levels. Especially landuse=retail is currently hardly visible on the map on any zoom level, this pull request should improve this.