Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render waterway=ditch thinner and only from zoom 16 onwards #1101

Closed
ghost opened this issue Oct 28, 2014 · 12 comments
Closed

Render waterway=ditch thinner and only from zoom 16 onwards #1101

ghost opened this issue Oct 28, 2014 · 12 comments

Comments

@ghost
Copy link

ghost commented Oct 28, 2014

When using waterway=ditch on a way, the default Mapnik rendering shows it from zoom level 13 onwards and shows it rather prominently. In areas where ditches are used heavily for draining land, it can leave the map looking very crowded at lower zoom levels

Messy waterway=ditch example: http://www.openstreetmap.org/#map=13/54.7150/-8.7022

Clean barrier=ditch example: http://www.openstreetmap.org/#map=16/54.6648/-8.7823

Might I propose that similar to barrier=ditch... waterway=ditch does not appear until zoom level 16 and that it is rendered at a lesser thickness

Thanks,

C

@ghost
Copy link
Author

ghost commented Oct 28, 2014

Just to add, I'm taking a good example from the OSM Humanitarian render:

http://www.openstreetmap.org/#map=15/54.7150/-8.7022&layers=H

This is that same area as above but the ways tagged waterway=ditch don't appear until z=15 and they are rendered very faint and narrow from z=15 up to z=20, which looks more pleasant

@matkoniecz
Copy link
Contributor

For reference - you want to revert part of #975 ("Increase width of stream, ditch, and drain")

@ghost
Copy link
Author

ghost commented Oct 28, 2014

Yes, I would like the ditch element to be modified

One of the issues solved in #975 was issue #967 ("Make drain line wider")

The user who made the request in #967 wanted waterway=drain to be a little wider and was OK for waterway=ditch to be retained as is or to be made wider at higher zoom levels

I think that only waterway=ditch should be narrower than it's current width at higher zoom to be similar in rendering to barrier=ditch or just slightly heavier. I think that also rendering them at z=13 is a bit early and can leave the low zoom map looking crowded

@matkoniecz matkoniecz added this to the Bugs and improvements milestone Oct 28, 2014
@matthijsmelissen
Copy link
Collaborator

Opposite of #967

@ghost
Copy link
Author

ghost commented Nov 6, 2014

#967 requested wider waterway=drain and yes, these should be retained at their current rendering

However, waterway=ditch should be reverted or modified to a narrower rendering and at larger zooms, similar to the examples on the HOSM render

@sommerluk
Copy link
Collaborator

The narrow rendering of waterway=ditch was bearly recognizable on the map. I would not rebder the line narrower.

But I think it could be useful to not render waterway=ditch from z=13, but from z=16 or even z=17.

@wmyrda
Copy link

wmyrda commented Jul 26, 2016

I vote for having waterway=stream render from z13 onward just like now, but make it thinner so on z13 it is not as wide as the road system which is more important and wider in the reality as well.
See http://www.openstreetmap.org/#map=13/49.6863/22.5913
Waterway=ditch/drain should also be thinner and probably appear only from z14 unless it has width=>2 to have it appear on z13 only for wide ditches with 2 meters or above

This is related to the #1781 (comment) Having more contrast for waterways would make it possible to see streams/ditches/drains even if one makes them thinner.

This might be related to #975

@matkoniecz
Copy link
Contributor

I think that it would make problem described in #2346 even worse, so I recommend closing this issue.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Nov 9, 2019

I agree with closing this issue. As mentioned above, rendering ditches narrower and at higher zoom levels than streams would encourage mappers to mis-use the waterway=ditch tag for narrow streams (see #2346)

Some large drainage (or irrigation) ditches are as wide as many canals. And for understanding the waterway network they are as important as streams in most places.

We could instead consider adjusting the rending based on the width=, as suggested in more recent issue #3795 and in #3354

@jeisenbe jeisenbe closed this as completed Nov 9, 2019
@pelderson
Copy link

I would like to ask for a slight reconsideration, i.e. to render waterway=ditch from z15 onwards instead of z14, OR render waterway=ditch shallower than now.

I will illustrate why. Consider https://www.openstreetmap.org/query?lat=52.08096&lon=4.43810#map=13/52.0745/4.4877
Please look at the rounded area below Stompwijk, and the area just left of it. Both have an elaborate system of parallel ditches. In the rounded area these have been mapped as water areas, while the area to the left of it has the ditches mapped as waterway=ditch. On the ground, these areas are similar in aspect. Now zoom to z14. Suddenly, the ditches all appear and the leftside area looks unrealistically blue, while the rounded area keeps blue and green realistic. At z15 the waterway=ditches look more realistic, at z16 it's ok. At z17, z18 and z19 the waterway=ditches are too narrow, but that's no big issue.

The "shallower rendering at z14" option (if it's applied to streams as well) would not lead to mappers abusing waterway=ditch for streams, I think. I can imagine mappers not knowing which one to take, because streams are frequently made to look like ditches and ditches are often styled as streams, but you can't solve that with rendering.

@imagico
Copy link
Collaborator

imagico commented Jan 28, 2021

For info: Starting zoom level for minor waterways was moved from z13 to z14 in #3467 without changing the styling so they appear very abrupt at z14 no matter how dense they are.

Most OSM based maps traditionally start minor waterways at z13, some at z12 (OpenTopoMap, most Thunderforest styles), few at z14 or later (and most which do tend to have a distinct non-rural focus). Most which start at z12 or z13 start relatively subtly though.

@pelderson
Copy link

For info: Starting zoom level for minor waterways was moved from z13 to z14 in #3467 without changing the styling so they appear very abrupt at z14 no matter how dense they are.

Most OSM based maps traditionally start minor waterways at z13, some at z12 (OpenTopoMap, most Thunderforest styles), few at z14 or later (and most which do tend to have a distinct non-rural focus). Most which start at z12 or z13 start relatively subtly though.

That change is about visual clutter below z14, I don't want to take a stand on that. Just concerned with the abrupt appearance of a very dominant water grid, especially compared to the way the almost identical ditches scale when mapped as a series of water areas. An even green area suddenly turns into a waterarea, then zooming in further it turns green again.

I would welcome a more subtle appearance of ditches at z14.

Having looked at more ditches in several countries, I drop the first option I mentioned. Most of these are less dense and less grid-like, and compared to other details z14 feels right for most ditches and streams to (subtly) appear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants