[new] promtail pipeline: Promtail Rate Limit stage #5048

[liguozhong]

Promtail Rate Limit stage #5048

[liguozhong]

@Whyeasy ,rate limit stage

[jeschkies]

Thanks for proposing this change 🙂

[jeschkies]

Thanks for responding so quickly. I wonder how we could add a test 🤔

[liguozhong]

Thanks for responding so quickly. I wonder how we could add a test 🤔

done. add TestLimitWaitPipeline test drop:false case ,and TestLimitDropPipeline test drop:true case

[jeschkies]

Nice. thanks for your patience!

[liguozhong]

continuous-integration/drone/pr — Build is failing
why,how to solve？

[jeschkies]

why,how to solve？

Probably a flaky test.

[KMiller-Grafana]

Every other stage provides one or more examples. Can you provide one for this limit stage?

[liguozhong]

why,how to solve？

Probably a flaky test.

done,thanks review

[cyriltovena]

@KMiller-Grafana We need your approval to merge this one.

Thank you !

[KMiller-Grafana]

I'm suggesting changes that give a bit of general understanding of what these rate limits are about. Specifically, they don't implement an ingestion rate limit within Promtail; they instead limit what Promtail pushes to Loki.

[09jvilla]

@liguozhong -- We made a few suggested improvements to the documentation. Can you take a look and merge them in if they look good to you?

Then we can get this merged to main :)

[liguozhong]

I'm suggesting changes that give a bit of general understanding of what these rate limits are about. Specifically, they don't implement an ingestion rate limit within Promtail; they instead limit what Promtail pushes to Loki.

done，thanks for your help.

[liguozhong]

@liguozhong -- We made a few suggested improvements to the documentation. Can you take a look and merge them in if they look good to you?

Then we can get this merged to main :)

done，thanks for your help.

[liguozhong]

I'm suggesting changes that give a bit of general understanding of what these rate limits are about. Specifically, they don't implement an ingestion rate limit within Promtail; they instead limit what Promtail pushes to Loki.

done,hi @KMiller-Grafana ,what else do i need to do? thanks

[KMiller-Grafana]

LGTM now. Thanks for the quick response.

[grafanabot]

The backport to release-2.5.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-5051-to-release-2.5.x origin/release-2.5.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 098b5a2d37d51d2e9c01adac6a4abd46a80fbc95
# Push it to GitHub
git push --set-upstream origin backport-5051-to-release-2.5.x
git switch main
# Remove the local backport branch
git branch -D backport-5051-to-release-2.5.x

Then, create a pull request where the base branch is release-2.5.x and the compare/head branch is backport-5051-to-release-2.5.x.

[grafanabot]

The backport to release-2.5.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-5051-to-release-2.5.x origin/release-2.5.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 098b5a2d37d51d2e9c01adac6a4abd46a80fbc95
# Push it to GitHub
git push --set-upstream origin backport-5051-to-release-2.5.x
git switch main
# Remove the local backport branch
git branch -D backport-5051-to-release-2.5.x

Then, create a pull request where the base branch is release-2.5.x and the compare/head branch is backport-5051-to-release-2.5.x.

[grafanabot]

The backport to release-2.5.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-5051-to-release-2.5.x origin/release-2.5.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 098b5a2d37d51d2e9c01adac6a4abd46a80fbc95
# Push it to GitHub
git push --set-upstream origin backport-5051-to-release-2.5.x
git switch main
# Remove the local backport branch
git branch -D backport-5051-to-release-2.5.x

Then, create a pull request where the base branch is release-2.5.x and the compare/head branch is backport-5051-to-release-2.5.x.