Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of per-stream Promtail rate limiting #5736

Open
KMiller-Grafana opened this issue Mar 31, 2022 · 2 comments
Open

Improve documentation of per-stream Promtail rate limiting #5736

KMiller-Grafana opened this issue Mar 31, 2022 · 2 comments
Assignees
Labels
keepalive An issue or PR that will be kept alive and never marked as stale.

Comments

@KMiller-Grafana
Copy link
Contributor

KMiller-Grafana commented Mar 31, 2022

After merge in of #5051, which adds a new per-stream rate-limiting pipeline stage to Promtail, improve these items:

  • The match pipeline stage schema needs a new stages entry for <limit_stage>.

Screen Shot 2022-03-31 at 9 55 20 AM

  • The description of the limit stage can become more clear to readers if it identifies that it is implementing rate limits on a per stream basis. The examples probably should include YAML for the match stage, and describe/state that it defines the stream that the rate limit is applied to.
@KMiller-Grafana KMiller-Grafana self-assigned this Mar 31, 2022
@stale
Copy link

stale bot commented May 1, 2022

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label May 1, 2022
@KMiller-Grafana KMiller-Grafana added keepalive An issue or PR that will be kept alive and never marked as stale. and removed stale A stale issue or PR that will automatically be closed. labels May 6, 2022
@cstyan
Copy link
Contributor

cstyan commented Nov 8, 2023

@JStickler not sure if this is still needed, I can check docs sometime this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keepalive An issue or PR that will be kept alive and never marked as stale.
Projects
None yet
Development

No branches or pull requests

2 participants