Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [k200] fix(blooms): Fully deduplicate chunks from FilterChunkRef responses #12835

Merged
merged 1 commit into from
Apr 30, 2024
Merged

chore: [k200] fix(blooms): Fully deduplicate chunks from FilterChunkRef responses #12835

merged 1 commit into from
Apr 30, 2024

Commits on Apr 30, 2024

  1. fix(blooms): Fully deduplicate chunks from FilterChunkRef responses (#… 

    …12807)

This PR aims for full de-duplication of chunks and series from filter requests from the index gateway to the bloom gateway.

Whenever we merge/de-duplicate slices, the inputs need to be sorted. It appears that the Removals (chunks) from the v1.Output are not guaranteed to be sorted.

When comparing ShortRefs, both From, Through, and Checksum need to be used.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
(cherry picked from commit a0f358f)
    @chaudum @grafana-delivery-bot
    chaudum authored and grafana-delivery-bot[bot] committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    54ef3a5 View commit details
    Browse the repository at this point in the history