Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [k200] fix(blooms): Fully deduplicate chunks from FilterChunkRef responses #12835

Merged
merged 1 commit into from
Apr 30, 2024
Merged

chore: [k200] fix(blooms): Fully deduplicate chunks from FilterChunkRef responses #12835

merged 1 commit into from
Apr 30, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport a0f358f from #12807

What this PR does / why we need it:

This PR aims for full de-duplication of chunks and series from filter requests from the index gateway to the bloom gateway.

Whenever we merge/de-duplicate slices, the inputs need to be sorted. It appears that the Removals (chunks) from the v1.Output are not guaranteed to be sorted.

When comparing ShortRefs, both From, Through, and Checksum need to be used.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@chaudum @grafana-delivery-bot
fix(blooms): Fully deduplicate chunks from FilterChunkRef responses (#…
54ef3a5 
…12807)

This PR aims for full de-duplication of chunks and series from filter requests from the index gateway to the bloom gateway.

Whenever we merge/de-duplicate slices, the inputs need to be sorted. It appears that the Removals (chunks) from the v1.Output are not guaranteed to be sorted.

When comparing ShortRefs, both From, Through, and Checksum need to be used.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
(cherry picked from commit a0f358f)
@grafanabot grafanabot requested a review from a team as a code owner April 30, 2024 11:34
@grafanabot grafanabot added backport size/L type/bug Somehing is not working as expected labels Apr 30, 2024
@grafanabot grafanabot requested a review from chaudum April 30, 2024 11:34
@chaudum chaudum merged commit 9e9852c into k200 Apr 30, 2024
62 checks passed
@chaudum chaudum deleted the backport-12807-to-k200 branch April 30, 2024 12:18
chaudum added a commit that referenced this pull request May 3, 2024
@grafanabot @chaudum
chore: [k200] fix(blooms): Fully deduplicate chunks from FilterChunkR…
8785e74 
…ef responses (#12835)

Backport a0f358f from #12807

Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaudum chaudum Awaiting requested review from chaudum

Assignees
No one assigned
Labels
backport size/L type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grafanabot @chaudum