Fix for create_or_modify_pyi read_text Windows Issue in component_meta.py #9242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some environments the `read_text()` call in `create_or_modify_pyi` will not use expected encoding when reading the `source_file`. In Unix environments (and presumably MacOS though I have not tested), this will default to use the 'utf-8' encoding, which is what the `source_file` are encoded in. In Windows, it seems to default to a different encoding when 'utf-8' should be selected.
SmirkingKitsune
changed the title
|
Makes sense, thanks for the contribution @SmirkingKitsune! |
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/ce9cfec38f8f8bb41a7464acad11c02f0ac94da4/gradio-4.42.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ce9cfec38f8f8bb41a7464acad11c02f0ac94da4#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/ce9cfec38f8f8bb41a7464acad11c02f0ac94da4/gradio-client-1.5.1.tgz |
abidlabs
approved these changes
Sep 2, 2024
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the
read_text()call increate_or_modify_pyiwill not use expected encoding when reading thesource_file.Description
This will declare the encoding that
read_textis supposed to use. It is reading files that are encoded in 'utf-8'. Windows seems to sometimes default to 'CP-1252', but not always. Issue was not present when tested in Unix. I think it is safer to explicitly declare the encoding to be 'utf-8' since the gradio source files that are being read are encoded in 'utf-8'.Closes: #8316 and Closes: #9241