Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent file traversals #6833

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Prevent file traversals #6833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bcb1048
prevent file traversal
abidlabs Dec 18, 2023
28724b3
fix
abidlabs Dec 18, 2023
42707f9
Merge branch 'main' into prevent-file-traversal
abidlabs Dec 18, 2023
8f2b498
add changeset
gradio-pr-bot Dec 18, 2023
7e8c70f
unit test
abidlabs Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tough-zoos-move.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"gradio": minor
---

feat:Prevent file traversals
2 changes: 1 addition & 1 deletion gradio/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,7 @@ def is_in_or_equal(path_1: str | Path, path_2: str | Path):
"""
path_1, path_2 = abspath(path_1), abspath(path_2)
try:
if str(path_1.relative_to(path_2)).startswith(".."): # prevent path traversal
if ".." in str(path_1.relative_to(path_2)): # prevent path traversal
return False
except ValueError:
return False
Expand Down
1 change: 1 addition & 0 deletions test/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,7 @@ def test_is_in_or_equal():
assert is_in_or_equal("/home/usr/notes.txt", "/home/usr/")
assert not is_in_or_equal("/home/usr/subdirectory", "/home/usr/notes.txt")
assert not is_in_or_equal("/home/usr/../../etc/notes.txt", "/home/usr/")
assert not is_in_or_equal("/safe_dir/subdir/../../unsafe_file.txt", "/safe_dir/")


@pytest.mark.parametrize(
Expand Down
Loading