-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent file traversals #6833
Prevent file traversals #6833
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/6df1e846352c26135ee970ec7d6bc772ea8b33d3/gradio-4.10.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@6df1e846352c26135ee970ec7d6bc772ea8b33d3#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @abidlabs !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to write a unit test for this!
I tried to write a unit test but for some reason I can't reproduce this behavior with fastapi's test client. Only curl seems to have this effect (and only if you pass in |
Apparently due to this PR urllib3/urllib3#1487. Let me see if I can write a unit test a different way |
Ok added a quick unit test. Thanks for the review @freddyaboulton! Will merge after CI is green |
Internal thread
Closes: #6816