Merge master into spanner-gapic-migration #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort. (googleapis#3391) * BigQuery: Add ORC format support for load jobs. Additionally, plumb in the (missing) Bigtable format support for federated tables. * add overrides, unit testing * Wire bigtable up into formatoptions * add copyright headers. * Convert BigtableColumn and BigtableColumnFamily to autovalue generation. * excise unused imports, address codacy kvetching about declaration order. * Address reviewer comments: formatting/whitespace, serializable, asserts * unused imports (asserts)
* regenerate libraries
…t in destination output (googleapis#3407)
…is#3408) the compatibility checker.
* Add test for setting project id in service options from credentials * Set projectId from credentials if available * Only set the projectId if not explicitly set
Adding region tags to include in Java Cloud Client Library docs on cloud.google.com
The text of the tags are displaying on the page. Need to find a different way to grab this text snippet.
* Requester-Pays bucket support. Code and integration test. To use this feature, set the "userProject" setting in the CloudStorageConfiguration. Optionally, set autoDetectRequesterPays to avoid automatically unset userProject if the bucket isn't requester-pays. * linter fixes * minor linter fixes * reviewer comments * apply all codacy recommendations * Put defaults back, remove unused import.
The current snippet injector does not work properly with google-java-format, because GJF formats short javadoc comments on one line, eg "/** comment */". However, the injector script looks for "/**" on a line by itself. The script will also not work if/when we move to Java 8, due to lack of parser support. This PR takes a different approach of not caring about Java syntax and copy-paste everything in the SNIPPET block. While less powerful, it is more robust. As written, the script is also easier to use. There's no need to tell it what file contains snippets and where to copy the snippets to. The script recursively scan given directories. Updates googleapis#2413. * license * Add test case for getSnip * Add support for cloud region tags to snippet.go
Generated with googleapis/gapic-generator#2131 to fix error in LoggingClient (see fix at andreamlin/google-cloud-java@386c987) Update google-common-protos to v 1.12.0. Add google-cloud-tasks for the first time. Remove LoggingSmokeTest.java, because the Logging smoke config has been removed from googleapis/googleapis, and the existing LoggingSmokeTest.java is incompatible with the current google-cloud-logging/src/main.
Update READMEs and URL links. Add ComputeExample.java which contains working client code for the Compute client.
…poch (googleapis#3434) * Fix the error when calling Timestamp.of(Date date) when date is pre epoch.
* bump some version * bump some version * trigger ci
…vironment variable (googleapis#3828) * Add assumptions to storage integration tests * Make testDownloadPublicBlobWithoutAuthentication skippable with an environment variable * Make testDownloadPublicBlobWithoutAuthentication skippable with an environment variable
- Remove @vam-google - Remove @andreamlin from all but Compute - Fix path prefix
* Add compute synth * Remove unused variable
* pubsub: reject expired and duplicate messages * add some lag time before rejecting expired messages
Pub/Sub may return up to 20MB of data from a single pull request. The default of 4MB is not enough for even one message of maximum size (10MB).
…gleapis#3809) * Use gax's async error handling now that it has been upstreamed * Bigtable: non-functional improvements * Add error handling examples to the javadocs * Use gax for error handling now that the code has been upstreamed * Fix outdated bigtable-admin readme * spacing * more docs * more docs * address feedback
the existing behavior is already correct; added comment explaining why
* Setup Kokoro to run codecov script after tests * Enable jacoco plugin to capture code coverage in clients
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
googlebot
added
the
cla: no
|
PTAL @snehashah16 @pongad |
sduskis
added
cla: yes
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
pongad
approved these changes
Oct 29, 2018
|
i did not manually review any files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.