Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigtable: non-functional improvements relating to error handling #3809

Merged
merged 11 commits into from
Oct 23, 2018
Merged

Bigtable: non-functional improvements relating to error handling #3809

merged 11 commits into from
Oct 23, 2018

Conversation

igorbernstein2
Copy link

  • Add error handling examples to the javadocs
  • Use gax for error handling now that the code has been upstreamed
  • Fix outdated bigtable-admin readme

@igorbernstein2
Use gax's async error handling now that it has been upstreamed
dcd7026
@igorbernstein2
Bigtable: non-functional improvements
caf2621 
* Add error handling examples to the javadocs
* Use gax for error handling now that the code has been upstreamed
* Fix outdated bigtable-admin readme
@igorbernstein2 igorbernstein2 requested a review from a team as a code owner October 11, 2018 15:27
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2018
@igorbernstein2 igorbernstein2 changed the title Bigtable: non-functional improvements Bigtable: non-functional improvements relating to error handling Oct 11, 2018
@sduskis sduskis added the api: bigtable Issues related to the Bigtable API. label Oct 12, 2018
kevinsi4508
kevinsi4508 reviewed Oct 12, 2018
View reviewed changes
Copy link

@kevinsi4508 kevinsi4508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things

...able-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java Show resolved Hide resolved
...oogle-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Show resolved Hide resolved
...oogle-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Outdated
* ApiFuture<Void> result = bigtableClient.bulkMutateRowsAsync(batch);
* ApiFuture<Void> resultFuture = bigtableClient.bulkMutateRowsAsync(batch);
*
* ApiFutures.addCallback(future, new ApiFutureCallback<Void>() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

...oogle-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Show resolved Hide resolved
...oogle-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Show resolved Hide resolved
@igorbernstein2
Copy link
Author

Thanks for the quick review. All feedback should be addressed

kevinsi4508
kevinsi4508 approved these changes Oct 12, 2018
View reviewed changes
Copy link

@kevinsi4508 kevinsi4508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@igorbernstein2
Copy link
Author

@pongad This should be ready for merging

@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2018
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2018
@igorbernstein2 igorbernstein2 merged commit 827230e into googleapis:master Oct 23, 2018
@igorbernstein2 igorbernstein2 deleted the bigtable-errors branch October 23, 2018 18:10
@sduskis sduskis mentioned this pull request Oct 23, 2018
Merged
@JesseLovelace JesseLovelace mentioned this pull request Oct 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduskis sduskis sduskis approved these changes

@kevinsi4508 kevinsi4508 kevinsi4508 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@igorbernstein2 @sduskis @kevinsi4508 @googlebot @kokoro-team