Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't bundle tests in jars #3728

Closed
elharo opened this issue Sep 25, 2018 · 1 comment
Closed

Don't bundle tests in jars #3728

elharo opened this issue Sep 25, 2018 · 1 comment
Assignees
@pmakani
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@elharo
Copy link
Contributor

elharo commented Sep 25, 2018

I downloaded and unzipped google-cloud-dns-0.63.0-alpha-tests.jar. Here's what I found inside it. We're definitely bundling the actual tests into these jars. We either shouldn't do this (just include mocks and the like) or otherwise not put these in the BOM.

$ jar tvf google-cloud-dns-0.63.0-alpha-tests.jar
     0 Thu Sep 20 16:47:10 EDT 2018 META-INF/
   617 Thu Sep 20 16:47:10 EDT 2018 META-INF/MANIFEST.MF
     0 Thu Sep 20 16:47:10 EDT 2018 com/
     0 Thu Sep 20 16:47:10 EDT 2018 com/google/
     0 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/
     0 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/
     0 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/it/
 19805 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsImplTest.class
  4099 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/ProjectInfoTest.class
 46519 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/it/ITDnsTest.class
  8991 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/SerializationTest.class
  4908 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/RecordSetTest.class
  3820 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsExceptionTest.class
  7528 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/ChangeRequestInfoTest.class
  2639 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest.class
   879 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$5.class
  3088 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsBatchResultTest.class
  5755 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/ZoneInfoTest.class
 28870 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsBatchTest.class
   672 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$3.class
   605 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsImplTest$1.class
   672 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$1.class
   879 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$6.class
   672 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$4.class
 15648 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/ZoneTest.class
  8405 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/ChangeRequestTest.class
  1207 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsOptionsTest.class
  6212 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsTest.class
   672 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$2.class
     0 Thu Sep 20 16:47:10 EDT 2018 META-INF/maven/
     0 Thu Sep 20 16:47:10 EDT 2018 META-INF/maven/com.google.cloud/
     0 Thu Sep 20 16:47:10 EDT 2018 META-INF/maven/com.google.cloud/google-cloud-dns/
  2486 Thu Sep 20 13:30:42 EDT 2018 META-INF/maven/com.google.cloud/google-cloud-dns/pom.xml
   131 Thu Sep 20 16:47:10 EDT 2018 META-INF/maven/com.google.cloud/google-cloud-dns/pom.properties
   246 Thu Sep 20 16:47:10 EDT 2018 META-INF/INDEX.LIST
@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Sep 26, 2018
@chingor13 chingor13 added the type: cleanup An internal cleanup or hygiene concern. label Sep 26, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Sep 26, 2018
pmakani pushed a commit to pmakani/google-cloud-java that referenced this issue Oct 25, 2018
googleapis#3707, googleapis#3708, googleapis#3728
b3ba3b0 
Fixes

* test-jar in google-cloud-bom

* Don't include multiple versions of same API in BOM

* Don't bundle tests in jars
@pmakani pmakani mentioned this issue Oct 25, 2018
Closed
pmakani pushed a commit to pmakani/google-cloud-java that referenced this issue Oct 30, 2018
googleapis#3707, googleapis#3728
bd573f5
@pmakani pmakani mentioned this issue Oct 30, 2018
Merged
@chingor13
Copy link
Contributor

This artifact's goal is to publish the actual tests. Whether or not these jars are of value is debatable.
These artifacts have already been removed from the bom, so we can close this issue.

@pmakani pmakani self-assigned this Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmakani pmakani

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chingor13 @JustinBeckwith @elharo @pmakani