Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-jar in google-cloud-bom #3707

Closed
elharo opened this issue Sep 20, 2018 · 1 comment
Closed

test-jar in google-cloud-bom #3707

elharo opened this issue Sep 20, 2018 · 1 comment
Assignees
@pmakani
Labels
status: in progress There is an open PR type: cleanup An internal cleanup or hygiene concern.

Comments

@elharo
Copy link
Contributor

elharo commented Sep 20, 2018

The BOM contains many dependencies like this one:

      <dependency>
        <groupId>com.google.cloud</groupId>
        <artifactId>google-cloud-storage</artifactId>
        <version>1.44.1-SNAPSHOT</version><!-- {x-version-update:google-cloud-storage:current} -->
        <type>test-jar</type>
      </dependency>

Is this really something we want in the BOM? I can't imagine clients should be depending on our tests. Can we take these out?
@elharo
Copy link
Contributor Author

elharo commented Sep 20, 2018

There are also a few of type testlib

@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Sep 21, 2018
@chingor13 chingor13 added the type: cleanup An internal cleanup or hygiene concern. label Sep 24, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Sep 24, 2018
pmakani pushed a commit to pmakani/google-cloud-java that referenced this issue Oct 25, 2018
googleapis#3707, googleapis#3708, googleapis#3728
b3ba3b0 
Fixes

* test-jar in google-cloud-bom

* Don't include multiple versions of same API in BOM

* Don't bundle tests in jars
@pmakani pmakani mentioned this issue Oct 25, 2018
Closed
pmakani pushed a commit to pmakani/google-cloud-java that referenced this issue Oct 30, 2018
googleapis#3707, googleapis#3728
bd573f5
@pmakani pmakani mentioned this issue Oct 30, 2018
Merged
@chingor13 chingor13 self-assigned this Dec 4, 2018
@chingor13 chingor13 mentioned this issue Dec 4, 2018
Merged
@chingor13 chingor13 added the status: in progress There is an open PR label Dec 4, 2018
@pmakani pmakani assigned pmakani and unassigned chingor13 Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmakani pmakani

Labels
status: in progress There is an open PR type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chingor13 @JustinBeckwith @elharo @pmakani