Add power battery% access #5871

StraToN · 2016-07-23T11:18:54Z

(repost of #5869 which was broken)
Only tested X11 and Windows by @vnen. Sorry I don't have a mac.

JOB IS NOT FINISHED FOR ALL PLATFORMS! DON'T MERGE BEFORE ALL PLATFORMS ARE TESTED !!

NEED TESTERS for iOS, OSX, WinRT and Android (may not compile for these).
Thanks

vnen · 2016-07-23T15:08:08Z

BTW, I wouldn't bother (for now) about WinRT. Right now it does not even compile.

vnen · 2016-07-23T18:04:01Z

platform/android/os_android.h

@@ -154,6 +155,8 @@ class OS_Android : public OS_Unix {
 	VideoPauseFunc video_pause_func;
 	VideoStopFunc video_stop_func;
 	SetKeepScreenOnFunc set_keep_screen_on_func;
+
+	power_android power_manager;


Should be power_android *power_manager;, right? This is what breaks the build for Android.

That's corrected. I just pushed the fix, but I can't affirm android will build, I'm almost certain there are other problems, especially in platform/android/power_android.cpp's method int Android_JNI_GetPowerInfo(int* plugged, int* charged, int* battery, int* seconds, int* percent)

akien-mga · 2016-07-25T06:59:57Z

It fails building on OSX and Android: https://travis-ci.org/godotengine/godot/builds/146963962

StraToN · 2016-07-25T07:43:23Z

@akien-mga Yes, I don't have a Mac to test, nor I have an Android environment.

akien-mga · 2016-07-25T07:49:43Z

Yes but you can check the build logs and see what are the issues :)

For Android you'd likely have to setup a build environment to test properly though, as there seem to be various issues: https://travis-ci.org/godotengine/godot/jobs/146963965
For OSX it looks like you just forgot to translate a SDL2 type to Dictionary: https://travis-ci.org/godotengine/godot/jobs/146963967

itsraineing · 2016-07-25T20:46:41Z

Adding #include <CoreFoundation/CoreFoundation.h> to platform/osx/power_osx.h and '-framework', 'IOKit' to the LDFLAGS in platform/osx/detect.py gets it to compile and work fine on OS X. I haven't tested iOS, but it seems to compile.

StraToN · 2016-07-26T06:38:07Z

@vnen I think it's possible to implement WinRT pretty easily using the Battery class documented here http://msdn.microsoft.com/library/windowsphone/develop/jj207231, according to SDL comment left in platform/winrt/power_winrt.cpp:41. I didn't take the time to do it as I couldn't test it anyway, however it seems we only need to return the values obtained with Battery::GetDefault().RemainingChargePercent and Battery::GetDefault().RemainingDischargeTime.

@GungnirInd Thanks a lot, it worked :)
Now testing is needed for OSX and iOS, for people insterested, thanks in advance!

vnen · 2016-08-13T19:09:33Z

I need to test this for Android. It'd be nice to merge this before 2.2. Since now I'm fixing the WinRT port, it can be added too for such platform.

StraToN · 2016-08-14T09:59:24Z

@vnen I'll try to get it to compile with Android now, even though I am not an Android developer. I suppose some includes are missing.

reduz · 2016-09-10T15:22:52Z

What's the status of this one?

StraToN · 2016-09-10T21:24:34Z

@reduz Still missing Android development by converting SDL code to Godot. I am not competent on this one yet 😕

reduz · 2016-09-10T22:14:01Z

you can ask @RandomShaper for help I guess

akien-mga · 2016-10-01T10:43:11Z

@StraToN The PR has conflicts, could you have a look at rebasing?

StraToN · 2016-10-01T11:33:43Z

@akien-mga Will do ASAP.

StraToN · 2016-10-05T21:39:11Z

Rebased.
Thanks again to @akien-mga for the (now usual) help :)

akien-mga · 2016-10-06T09:18:10Z

Looking at the commit history, there's still something fishy though.. :/

StraToN · 2016-10-06T11:38:43Z

Indeed, looks like I left 2 useless commits . Will correct it tonight

StraToN · 2016-10-22T16:03:33Z

@akien-mga Corrected. Do you validate? :)

akien-mga · 2016-10-22T16:08:00Z

Looks good commit-wise from a quick glance :)

vnen · 2016-10-22T16:48:50Z

platform/winrt/power_winrt.cpp

@@ -0,0 +1,78 @@
+/*************************************************************************/
+/*  power_winrt.h                                                   */


Forgot to change the file name here.

Corrected. Thanks !

akien-mga · 2017-01-10T13:18:43Z

@StraToN You have some rebase work ahead :)

Done: - X11, server (tested) - Windows (developed, would be nice to retest) - OSX (not tested) Prepared (not developed): - Android (code is here, but may not compile) - iphone - winrt - bb10 - haiku - javascript

StraToN · 2017-01-19T09:39:48Z

@akien-mga Done ;)

Ping @vnen for winrt and Mux213 on IRC for osx

StraToN · 2017-01-19T10:02:53Z

platform/osx/power_osx.h

+	int percent_left;
+	PowerState power_state;
+	void checkps(CFDictionaryRef dict, bool * have_ac, bool * have_battery, bool * charging);
+	bool GetPowerInfo_MacOSX(/*PowerState * state, int *seconds, int *percent*/);


I should kick this comment with parameters out.

akien-mga · 2017-03-04T17:06:46Z

Merged manually in 94103c0.

Please open a new issue to keep track of the state of this feature on all platforms (implemented/working) so that we make sure it's all good for 3.0.

It was initially implemented in godotengine#5871 for Godot 3.0, but never really completed or thoroughly tested for most platforms. It then stayed in limbo and nobody seems really keen to finish it, so it's better to remove it in 4.0, and re-add eventually (possibly with a different API) if there's demand and an implementation confirmed working on all platforms. Closes godotengine#8770.

StraToN mentioned this pull request Jul 23, 2016

Add power battery% access #5869

Closed

akien-mga added feature proposal topic:core topic:porting needs testing labels Jul 23, 2016

StraToN force-pushed the godot-power-battery branch 2 times, most recently from 904b5c8 to 29228a6 Compare July 23, 2016 12:54

vnen reviewed Jul 23, 2016
View reviewed changes

StraToN force-pushed the godot-power-battery branch 3 times, most recently from 663b2e4 to 7944b97 Compare July 24, 2016 09:03

StraToN force-pushed the godot-power-battery branch from 7944b97 to 4ed666a Compare July 26, 2016 04:36

StraToN closed this Aug 14, 2016

StraToN reopened this Aug 14, 2016

StraToN force-pushed the godot-power-battery branch from aca95f3 to 49a9ef6 Compare October 5, 2016 21:23

vnen mentioned this pull request Oct 18, 2016

Battery Notification #314

Closed

StraToN force-pushed the godot-power-battery branch 2 times, most recently from 49a9ef6 to 9232bb7 Compare October 22, 2016 16:02

vnen reviewed Oct 22, 2016

View reviewed changes

StraToN force-pushed the godot-power-battery branch from 9232bb7 to a421522 Compare October 23, 2016 16:59

Add power battery% access

31b6a7c

Done: - X11, server (tested) - Windows (developed, would be nice to retest) - OSX (not tested) Prepared (not developed): - Android (code is here, but may not compile) - iphone - winrt - bb10 - haiku - javascript

StraToN force-pushed the godot-power-battery branch from a421522 to 27cfdee Compare January 18, 2017 21:33

Correct OSX LDFLAGS and Android code.

917ce78

StraToN force-pushed the godot-power-battery branch from 27cfdee to 917ce78 Compare January 18, 2017 21:44

akien-mga added this to the 3.0 milestone Jan 19, 2017

StraToN commented Jan 19, 2017

View reviewed changes

akien-mga closed this Mar 4, 2017

StraToN deleted the godot-power-battery branch July 26, 2017 11:20

akien-mga mentioned this pull request Feb 14, 2020

Remove incomplete battery status/power API #36212

Merged

Calinou mentioned this pull request Apr 29, 2022

Add support for controller-based motion controls (gyroscope, accelerometer, …) godotengine/godot-proposals#2829

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add power battery% access #5871

Add power battery% access #5871

StraToN commented Jul 23, 2016

vnen commented Jul 23, 2016

vnen Jul 23, 2016

StraToN Jul 24, 2016

akien-mga commented Jul 25, 2016

StraToN commented Jul 25, 2016

akien-mga commented Jul 25, 2016

itsraineing commented Jul 25, 2016

StraToN commented Jul 26, 2016

vnen commented Aug 13, 2016

StraToN commented Aug 14, 2016

reduz commented Sep 10, 2016

StraToN commented Sep 10, 2016

reduz commented Sep 10, 2016

akien-mga commented Oct 1, 2016

StraToN commented Oct 1, 2016

StraToN commented Oct 5, 2016

akien-mga commented Oct 6, 2016

StraToN commented Oct 6, 2016

StraToN commented Oct 22, 2016

akien-mga commented Oct 22, 2016

vnen Oct 22, 2016

StraToN Oct 23, 2016

akien-mga commented Jan 10, 2017

StraToN commented Jan 19, 2017 •

edited

Loading

StraToN Jan 19, 2017 •

edited

Loading

akien-mga commented Mar 4, 2017

		@@ -0,0 +1,78 @@
		/*************************************************************************/
		/* power_winrt.h */

Add power battery% access #5871

Add power battery% access #5871

Conversation

StraToN commented Jul 23, 2016

vnen commented Jul 23, 2016

vnen Jul 23, 2016

Choose a reason for hiding this comment

StraToN Jul 24, 2016

Choose a reason for hiding this comment

akien-mga commented Jul 25, 2016

StraToN commented Jul 25, 2016

akien-mga commented Jul 25, 2016

itsraineing commented Jul 25, 2016

StraToN commented Jul 26, 2016

vnen commented Aug 13, 2016

StraToN commented Aug 14, 2016

reduz commented Sep 10, 2016

StraToN commented Sep 10, 2016

reduz commented Sep 10, 2016

akien-mga commented Oct 1, 2016

StraToN commented Oct 1, 2016

StraToN commented Oct 5, 2016

akien-mga commented Oct 6, 2016

StraToN commented Oct 6, 2016

StraToN commented Oct 22, 2016

akien-mga commented Oct 22, 2016

vnen Oct 22, 2016

Choose a reason for hiding this comment

StraToN Oct 23, 2016

Choose a reason for hiding this comment

akien-mga commented Jan 10, 2017

StraToN commented Jan 19, 2017 • edited Loading

StraToN Jan 19, 2017 • edited Loading

Choose a reason for hiding this comment

akien-mga commented Mar 4, 2017

StraToN commented Jan 19, 2017 •

edited

Loading

StraToN Jan 19, 2017 •

edited

Loading