Add power battery% access #5869
Conversation
…ished) and WinRT. Only test X11.
|
|
||
| int Android_JNI_GetPowerInfo(int* plugged, int* charged, int* battery, int* seconds, int* percent) | ||
| { | ||
| /* |
There was a problem hiding this comment.
I'm not really sure this should be commented :)
There was a problem hiding this comment.
I believe this directly comes from SDL @bojidar-bg
I'll remove it if you think it has to be.
There was a problem hiding this comment.
Well, it's mostly useless to have a function that has a only a return 0 inside it...
There was a problem hiding this comment.
BTW, it would be nice to make it very clear in all files which code chunks come from SDL (and maybe even the version) so that we can compare with upstream and do changes as needed in the future.
If complete files come from SDL and were just "ported" to Godot's standard library, you could put this in a comment just below the Godot license header.
There was a problem hiding this comment.
This function was imported from SDL but I am unable to test it so I commented it out. It's here to be filled in the future.
Also, I'm unable to get this branch updated with current master in order to shoot down conflicts, so I'll close this PR and remake it completely from scratch.
@akien-mga Oops I forgot to add these comments. It'll be done in the next commit, as there should be more commits for platforms I couldn't test. See #5871
| @@ -0,0 +1,10 @@ | |||
| Godot Engine is a project initiated by Juan "reduz" Linietsky and Ariel "punto" Manzur. | |||
There was a problem hiding this comment.
I think this should probably be added in another PR, with a first attempt at writing the mentioned exhaustive list of contributors.
Only tested X11 and Windows by @vnen. Sorry I don't have a mac
JOB IS NOT FINISHED FOR ALL PLATFORMS! NEED TESTERS for iOS, OSX, WinRT and Android (may not compile for these).
Thanks