Battery Notification #314

avarisclari · 2014-04-22T04:54:54Z

Is there any form of battery monitor built in? If not, how much work would it be to add such a feature. I know it's not a major feature, but still nice to be able to say in an application "Your battery is low, please save and quit, or find the nearest power source."

amagnoni · 2014-04-22T06:21:52Z

android automatic notify drawing over a confirmation window!

avarisclari · 2014-04-22T06:39:59Z

Is the feature available on PC's (laptops)

reduz · 2014-04-22T17:49:21Z

this API is probably available everywhere, I think SDL has it:
https://wiki.libsdl.org/SDL_GetPowerInfo
so if if anyone wants to port this code to Godot be welcome.
Could be functions added to OS

StraToN · 2016-04-29T09:23:40Z

WINDOWS AND OSX TESTERS NEEDED PLEASE ! SEE LIST BELOW.
This feature is currently in development on this fork branch : https://github.com/StraToN/godot/tree/314-battery-notification
Current status:

X11 : done, tested on GNU/Linux *but needs tests on BSD
OSX : done, not tested
IOS (iphone) : not done, WIP
Windows : done, not tested
WinRT : not done, will have to wait for experienced WinRT dev...
Android : partially done, the platform-specific code is ready but I don't know where to put it, so it's commented out atm (https://github.com/StraToN/godot/blob/314-battery-notification/platform/android/power_android.cpp#L38)
bb10 : not done
Haiku : not done
isim : not done
javascript : not done (is that a platform?? :s )
server : not done (is that a platform?? what is the difference between this and X11??)

Calinou · 2016-04-29T09:49:48Z

server : not done (is that a platform?? what is the difference between this and X11??)

Technically, yes. server is designed for running on headless GNU/Linux (and BSD) operating systems, without requiring any X11 dependency. It can also be faster in many cases. That makes it suitable for dedicated game servers, running scripts like asset conversion…

punto- · 2016-04-29T10:07:54Z

"javascript" is html5, I don't know if there's apis to expose the battery
status to a website

On 29 April 2016 at 06:50, Calinou notifications@github.com wrote:

server : not done (is that a platform?? what is the difference between
this and X11??)

Technically, yes. server is designed for running on headless GNU/Linux
(and BSD) operating systems, without requiring any X11 dependency. It can
also be faster in many cases. That makes it suitable for dedicated game
servers, running scripts like asset conversion…

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#314 (comment)

SuperUserNameMan · 2016-04-29T10:18:55Z

@punto- : there is a new javascript Battery Status Web API, but it is still a W3C Proposed Recommendation. It is mainly available on Firefox and Chrome (on Android and PC)

https://developer.mozilla.org/en-US/docs/Web/API/Battery_Status_API
https://w3c.github.io/battery/

StraToN · 2016-04-29T10:30:11Z

@Calinou OK, so server would actually work the exact same way as X11. I suppose that, of course a server should never run on battery, but hey, people mind their own business ;)

@punto- @SuperUserNameMan I guess we should then simply wait for this one. Keeping it warm.

Oh, also I edited my last post. Tests were not driven for *BSD, I updated the status list.

vnen · 2016-04-29T17:14:41Z

I'll test this for Windows.

vnen · 2016-04-29T17:52:53Z

@StraToN first, there's an error on line 13 of the SCsub file for Windows. It is now 'power_windows.cpp", when it should be "power_windows.cpp" (without comma at the end).

Even after this fix I can't compile though. Got a bunch of errors:

c:\users\george\workspace\godot\godot-src\platform\windows\os_windows.h(133) : e
rror C2143: syntax error : missing ';' before '*'
c:\users\george\workspace\godot\godot-src\platform\windows\os_windows.h(133) : e
rror C2143: syntax error : missing ';' before '*'
c:\users\george\workspace\godot\godot-src\platform\windows\os_windows.h(133) : e
rror C4430: missing type specifier - int assumed. Note: C++ does not support def
ault-intc:\users\george\workspace\godot\godot-src\platform\windows\os_windows.h(
133) : error C4430: missing type specifier - int assumed. Note: C++ does not sup
port default-int

platform\windows\power_windows.cpp(34) : error C2065: 'SYSTEM_POWER_STATUS' : un
declared identifier
platform\windows\power_windows.cpp(34) : error C2146: syntax error : missing ';'
 before identifier 'status'
platform\windows\power_windows.cpp(34) : error C2065: 'status' : undeclared iden
tifier
platform\windows\power_windows.cpp(35) : error C2065: 'FALSE' : undeclared ident
ifier
platform\windows\power_windows.cpp(38) : error C2065: 'status' : undeclared iden
tifier
scons: *** [platform\windows\godot_win.windows.opt.tools.32.obj] Error 2
platform\windows\power_windows.cpp(38) : error C3861: 'GetSystemPowerStatus': id
entifier not found
platform\windows\power_windows.cpp(42) : error C2065: 'status' : undeclared iden
tifier
platform\windows\power_windows.cpp(42) : error C2228: left of '.BatteryFlag' mus
t have class/struct/union
C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\INCLUDE\xlocale(337) : wa
rning C4530: C++ exception handler used, but unwind semantics are not enabled. S
pecify /EHsc
        type is 'unknown-type'
platform\windows\power_windows.cpp(44) : error C2065: 'status' : undeclared iden
tifier
platform\windows\power_windows.cpp(44) : error C2228: left of '.BatteryFlag' mus
t have class/struct/union
        type is 'unknown-type'
platform\windows\power_windows.cpp(45) : error C2100: illegal indirection
platform\windows\power_windows.cpp(46) : error C2065: 'status' : undeclared iden
tifier
platform\windows\power_windows.cpp(46) : error C2228: left of '.BatteryFlag' mus
t have class/struct/union
        type is 'unknown-type'
platform\windows\power_windows.cpp(47) : error C2100: illegal indirection
platform\windows\power_windows.cpp(48) : error C2065: 'TRUE' : undeclared identi
fier
platform\windows\power_windows.cpp(49) : error C2065: 'status' : undeclared iden
tifier
platform\windows\power_windows.cpp(49) : error C2228: left of '.ACLineStatus' mu
st have class/struct/union
        type is 'unknown-type'
platform\windows\power_windows.cpp(50) : error C2100: illegal indirection
platform\windows\power_windows.cpp(51) : error C2065: 'TRUE' : undeclared identi
fier
platform\windows\power_windows.cpp(53) : error C2100: illegal indirection
platform\windows\power_windows.cpp(54) : error C2065: 'TRUE' : undeclared identi
fier
platform\windows\power_windows.cpp(60) : error C2065: 'status' : undeclared iden
tifier
platform\windows\power_windows.cpp(60) : error C2228: left of '.BatteryLifePerce
nt' must have class/struct/union
        type is 'unknown-type'
platform\windows\power_windows.cpp(61) : error C2065: 'status' : undeclared iden
tifier
platform\windows\power_windows.cpp(61) : error C2228: left of '.BatteryLifeTime'
 must have class/struct/union
        type is 'unknown-type'
platform\windows\power_windows.cpp(71) : error C2065: 'TRUE' : undeclared identi
fier
scons: *** [platform\windows\power_windows.windows.opt.tools.32.obj] Error 2
c:\users\george\workspace\godot\godot-src\platform\windows\os_windows.h(133) : e
rror C2143: syntax error : missing ';' before '*'
c:\users\george\workspace\godot\godot-src\platform\windows\os_windows.h(133) : e
rror C4430: missing type specifier - int assumed. Note: C++ does not support def
ault-int
scons: *** [platform\windows\joystick.windows.opt.tools.32.obj] Error 2
platform\windows\os_windows.cpp(989) : error C2065: 'power_manager' : undeclared
 identifier
platform\windows\os_windows.cpp(989) : error C2061: syntax error : identifier 'P
owerWindows'
scons: *** [platform\windows\os_windows.windows.opt.tools.32.obj] Error 2
scons: building terminated because of errors.

akien-mga · 2016-04-29T17:55:53Z

Tested on X11, it seems to work fine. Like @StraToN reported, I also get -1 for get_power_seconds_left, I'll see if I have more luck with the SDL API directly and/or if they have a bug report about it.

With the cable plugged in and the battery fully charged, I got POWERSTATE_UNKNOWN instead of POWERSTATE_CHARGED. I'm now charging it fully again to see if I can reproduce it.

Also the enums in the help are sorted alphabetically instead of by value, it would be nice to fix that.

StraToN · 2016-04-29T20:58:42Z

@vnen Thanks a lot for your tests ! There was a missing include (I forgot windows.h). This is corrected now, please pull and try again.

@akien-mga You just need to compile libsdl and run make in src/tests. There lies a test program for power management testing.

vnen · 2016-04-30T00:52:52Z

@StraToN still missing the platform/windows/SCsub correction. Other than that it seems to be working perfectly. Unfortunately, my Windows laptop is not showing the remaining battery time (only percentage), so I can't tell if OS.get_power_seconds_left() is working as intended (I'm always getting -1, since the OS is not calculating it).

As a note, it shows the power state as NO_BATTERY on my desktop, which I guess is intended behavior.

StraToN · 2016-04-30T07:47:49Z

@vnen Ah, I see the error now. My eyes were closing yesterday, I didn't see it. I'll correct this ASAP.
edit : done.

Concerning get_power_seconds_left(), I invite you to compile SDL as well as demo programs it features, to see if it succeeds.

Other than that, no PR until most platorms are tested and compile. We can't merge code thats breaks Godot. Looking at OSX users here in particular 😊

StraToN · 2016-06-15T14:05:12Z

ping
Still needing OSX testers.

vnen · 2016-06-15T15:16:41Z

@trollworkout uses OSX, I believe.

reduz · 2016-06-15T15:33:04Z

ah I have a mac now, i could test..

On Wed, Jun 15, 2016 at 12:16 PM, George Marques notifications@github.com
wrote:

@trollworkout https://github.com/trollworkout uses OSX, I believe.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#314 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AF-Z2xZXM33o-tS8kZxIvpFHKnzOIkd4ks5qMBdngaJpZM4B0TAL
.

ghost · 2016-06-15T20:58:06Z

I got OSX. I'm looking above see how I can test this.

akien-mga · 2016-07-19T09:11:09Z

@StraToN I'd suggest your cleanup your branch (merge some of the commits together, 16 commits is too much for this feature), rebase on top of master HEAD and make a pull request. Right now your work is kind of hidden, and forgotten.

bojidar-bg · 2016-10-18T18:26:30Z

Was the PR merged in the end?

ghost · 2016-10-18T18:45:01Z

I never ended up checking this :D

vnen · 2016-10-18T18:45:16Z

@bojidar-bg no, still open: #5871

wt · 2017-05-14T01:21:24Z

The last comment on #5871 seems to indicate that it was merged. Maybe this one can be closed?

akien-mga · 2017-05-14T17:24:38Z

It still needs to be implemented on various platforms. @StraToN, I leave it up to you to either update this issue with the current implementation status, or maybe close it and open a new one for that, as it might be clearer.

StraToN · 2017-05-15T08:51:48Z

@akien-mga I'll create a new issue with the current implementation status & what's missing. That's cleaner this way ;)

kubecz3k added feature proposal topic:core labels Oct 29, 2015

akien-mga added this to the Later milestone Oct 29, 2015

akien-mga removed this from the Later milestone Jan 5, 2016

akien-mga assigned StraToN Apr 14, 2016

akien-mga closed this as completed May 15, 2017

akien-mga added this to the 3.0 milestone May 15, 2017

StraToN mentioned this issue May 15, 2017

Power/Battery management #8770

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Battery Notification #314

Battery Notification #314

avarisclari commented Apr 22, 2014

amagnoni commented Apr 22, 2014

avarisclari commented Apr 22, 2014

reduz commented Apr 22, 2014

StraToN commented Apr 29, 2016 •

edited

Loading

Calinou commented Apr 29, 2016 •

edited

Loading

punto- commented Apr 29, 2016

SuperUserNameMan commented Apr 29, 2016

StraToN commented Apr 29, 2016 •

edited

Loading

vnen commented Apr 29, 2016

vnen commented Apr 29, 2016

akien-mga commented Apr 29, 2016

StraToN commented Apr 29, 2016

vnen commented Apr 30, 2016

StraToN commented Apr 30, 2016 •

edited

Loading

StraToN commented Jun 15, 2016

vnen commented Jun 15, 2016

reduz commented Jun 15, 2016

ghost commented Jun 15, 2016

akien-mga commented Jul 19, 2016

bojidar-bg commented Oct 18, 2016

ghost commented Oct 18, 2016

vnen commented Oct 18, 2016

wt commented May 14, 2017

akien-mga commented May 14, 2017

StraToN commented May 15, 2017

Battery Notification #314

Battery Notification #314

Comments

avarisclari commented Apr 22, 2014

amagnoni commented Apr 22, 2014

avarisclari commented Apr 22, 2014

reduz commented Apr 22, 2014

StraToN commented Apr 29, 2016 • edited Loading

Calinou commented Apr 29, 2016 • edited Loading

punto- commented Apr 29, 2016

SuperUserNameMan commented Apr 29, 2016

StraToN commented Apr 29, 2016 • edited Loading

vnen commented Apr 29, 2016

vnen commented Apr 29, 2016

akien-mga commented Apr 29, 2016

StraToN commented Apr 29, 2016

vnen commented Apr 30, 2016

StraToN commented Apr 30, 2016 • edited Loading

StraToN commented Jun 15, 2016

vnen commented Jun 15, 2016

reduz commented Jun 15, 2016

ghost commented Jun 15, 2016

akien-mga commented Jul 19, 2016

bojidar-bg commented Oct 18, 2016

ghost commented Oct 18, 2016

vnen commented Oct 18, 2016

wt commented May 14, 2017

akien-mga commented May 14, 2017

StraToN commented May 15, 2017

StraToN commented Apr 29, 2016 •

edited

Loading

Calinou commented Apr 29, 2016 •

edited

Loading

StraToN commented Apr 29, 2016 •

edited

Loading

StraToN commented Apr 30, 2016 •

edited

Loading