Tweak the name for new animations in the editor #48570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use snake_case to "suggest" the naming that fits the Godot style guide.
- Fully spell out "new_animation" since both editors can fit it in full.
- Don't internationalize the new animation name to have consistent
behavior between both editors.
- Since the recommendation is to follow snake_case, special characters
should also be avoided in the name to make animations easier to refer
to in code.
Calinou
force-pushed
the
animation-editors-new-name
branch
from
442b534
to
23dcc33
Compare
fire-forge
approved these changes
Jul 13, 2022
|
Does this supersede #69442? |
TokageItLab
approved these changes
Jan 20, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically not a breaking change because it only impacts the name of animations added via the editor (not by code). However, it can break user expectations for those who are used to naming their animations Like This. Due to this, I'm not sure if this should be cherry-picked to the
3.xbranch (apart of the translation consistency fix).