Fixed SpriteFrame allowed entering an empty name

[ZangEldor]

Fixed issue #70769 where the user could enter an empty name in the SpriteFrame window.
Added a check for an empty string and if so, the name is changed to TTR("Default").
Try to change the name in the attached sample project and see that it is now changes to Default instead of staying as an empty string.
Empty SpriteFrame Test.zip

Bugsquad edit:

• Fix SpriteFrames window allow setting animation name to empty string #70769

[MewPurPur]

Should be lowercase "default" to match other areas of the engine where deleting the name switches to the default one. Otherwise looks good.

[ZangEldor]

Should be lowercase "default" to match other areas of the engine where deleting the name switches to the default one. Otherwise looks good.

My reason was that default (in lowecase) doesn't have a translation to other languages in the editor/translations/*.po files, rather than Default which has a translation - therefore I think that Default enables more user-friendly experience to non-english users.

[akien-mga]

FYI, there's the same problem with invalid email to author this commit as discussed in #70675 (comment).

[akien-mga]

I rebased the commit and changed it to use "New Anim" without translation as a fallback name. This is the same name used when adding a new animation, so it's basically equivalent to resetting the name to what the default would be.

Edit: Actually I changed it to new_animation after rebasing on latest master to match #48570.

[akien-mga]

Thanks!

[hsandt]

Thanks, I tested in 4.0.rc4 and the base functionality is working.

However I got this error message in the console:

Add Animation
Animation '' doesn't exist.
Rename Animation

I also noticed that if you rename "new_animation" specifically to "", it conflicts with itself and is renamed "new_animation_1". This only occurs once, next time you rename it, it will be renamed back to "new_animation".

Of course it's minor compared to the original issue. I can reopen a new issue for these.

[akien-mga]

Please do, this could be polished further probably.