Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: write debug log for binary files #190

Merged
merged 3 commits into from
Jun 11, 2021
Merged

fix: write debug log for binary files #190

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba33659
fix: write debug log for binary files
dclayton-godaddy Jun 9, 2021
4dc5ab8
fix lint issue
dclayton-godaddy Jun 10, 2021
5a5f436
Merge branch 'main' into binary-logging
tarkatronic Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tartufo/scanner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,10 +388,11 @@ def _iter_diff_index(
"""
diff: git.Diff
for diff in diff_index:
file_path = diff.b_path if diff.b_path else diff.a_path
printable_diff: str = diff.diff.decode("utf-8", errors="replace")
if printable_diff.startswith("Binary files"):
self.logger.debug('Binary file skipped: %s', file_path)
continue
file_path = diff.b_path if diff.b_path else diff.a_path
if self.should_scan(file_path):
yield (printable_diff, file_path)

Expand Down