Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write debug log for binary files #190

Merged
merged 3 commits into from
Jun 11, 2021

Conversation

dclayton-godaddy
Copy link
Contributor

@dclayton-godaddy dclayton-godaddy commented Jun 9, 2021

It took several hours to find out why package-lock.json file was not being scanned. Turns out it was marked as binary and therefore was skipped. Verbose logging would have saved tons of time.

To help us get this pull request reviewed and merged quickly, please be sure to include the following items:

  • Tests (if applicable)
  • Documentation (if applicable)
  • Changelog entry
  • A full explanation here in the PR description of the work done

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Backward Compatibility

Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?

  • Yes (backward compatible)
  • No (breaking changes)

Issue Linking

What's new?

  • Added debug logging for skipped binary files

It took several hours to find out why package-lock.json file was not being scanned. Turns out it was marked a binary and therefore was skipped. Verbose logging would have saved tons of time.
Copy link
Contributor

@tarkatronic tarkatronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks @dclayton-godaddy

@tarkatronic
Copy link
Contributor

@dclayton-godaddy It looks like a few linters failed on this. The problems are mostly unrelated; likely there were new releases of pylint and mypy that work every so slightly differently. I'll handle those in another quick PR. The failure of black is legit though; it's picky about the type of quotes used -- double quotes only. I would recommend making sure you have pre-commit set up to catch these at commit time!

@dclayton-godaddy
Copy link
Contributor Author

@jwilhelm-godaddy ya, I usually do. Thanks. Updated.

@tarkatronic tarkatronic merged commit 21e5e1d into godaddy:main Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants