-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Full Site Editing #855
Draft
jrtashjian
wants to merge
56
commits into
master
Choose a base branch
from
full-site-editing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 10 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
33a4a38
Moving in FSE related files.
jrtashjian 6395bed
Add missed files
jrtashjian ee08546
Remove old template files
jrtashjian c5be03a
phpcs fixes and bump requirements
jrtashjian 2ce9c8a
Move conversion class into it's own file
jrtashjian 2ef3c54
Add johnpbloch/wordpress-core for intellisense support
jrtashjian ef0ae79
More cleanup
jrtashjian ab98087
fix typo in migration
jrtashjian 3fc5388
simple typo fix
AnthonyLedesma 69b2296
revert suggestion changes
AnthonyLedesma 7dd8b18
Fix trendy
jrtashjian a979875
Ignore linting index.php
jrtashjian 8d25dc6
Add WooCommerce templates
jrtashjian 2785be9
re-export theme.json
jrtashjian b80446a
Tweak post query in templates
jrtashjian eebaf9f
re-export Modern
jrtashjian 1278cc5
re-export default
jrtashjian 2f9493e
Tweak social icons in footer
jrtashjian ec0f738
Fixes FSE: Footer Menu Duplicated #862
jrtashjian 577719f
re-export styles
jrtashjian 2b2abaa
re-export styles
jrtashjian 2d0363e
fix footer spacing
jrtashjian 0df3a83
update site and nav fonts
jrtashjian 4897e9e
Add "global" header option and update single/page templates
jrtashjian aa4a24c
Fix header migration
jrtashjian 6f8f7ce
remove old templates
jrtashjian c2c2cf4
setup git export
jrtashjian 3970aae
fix ignore
jrtashjian 0e833f9
additional templates
jrtashjian 1587eff
Disable CoBlocks Labs Site Design
jrtashjian 44abe37
re-configure composer
jrtashjian ee3a0c9
Rename phpcs and phpunit files
jrtashjian 245d8ea
🪓 Remove Grunt and Yarn
jrtashjian 32c3f13
reconfigure package.json
jrtashjian f626f4a
remove old webpack configs
jrtashjian ed52877
move deactivate-modal to src/
jrtashjian 2436f08
add npm deps
jrtashjian f507ea1
remove old scripts
jrtashjian 3db6995
enqueue deactivation modal scripts
jrtashjian 681a71f
Attempt to fix tests workflow
jrtashjian 6635dc0
fix build command
jrtashjian d81f2e1
Fix test:js
jrtashjian fdb71c6
Fix coding standards workflow
jrtashjian d03af6b
fix eslint runner
jrtashjian 2f97399
Fix php linting
jrtashjian 85ff5a9
Remove old phpunit tests
jrtashjian ecaca70
Fix update-translations workflow
jrtashjian afa04c4
fix phpunit test workflow
jrtashjian 7ad266e
test if we need executablePath
jrtashjian db970ba
"npm run" needed
jrtashjian ee70a2b
Set chromeLaunchConfig for CI
jrtashjian 1060bbb
Composer "format" should be "lint:fix"
jrtashjian 35f45da
Fix full & wide alignment
jrtashjian a970e8f
Improve colors. Improve spacing for header-1 (#867)
jlemay-godaddy 754f91f
WPEX-2977 - fix styles quote block in Go FSE (#868)
snovosel-godaddy cddc140
Fix navigation headings (#866)
eherman-godaddy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spacing here seems off. Also, please speak to why we would include
create-block-theme
in the.wp-env.json
file. I presume this may be related to testing?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
create-block-theme
plugin is not just for testing but for development which is why included it. It will help anyone modifying styles and/or templates to work inside the site editor and export directly to the local directory and then commit to our repo.