Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Full Site Editing #855

Draft
wants to merge 56 commits into
base: master
Choose a base branch
from
Draft

[WIP] Full Site Editing #855

wants to merge 56 commits into from

Conversation

jrtashjian
Copy link
Member

@jrtashjian jrtashjian commented Apr 6, 2023

This PR transitions Go from a Classic theme into a Full Site Editing supported Block theme.

Migration from Customizer

Site Identity:

  • Site logo

  • Site icon

  • Site title

  • Hide site title toggle

    • theme_mod: hide_site_title
  • Tagline

    • theme_mod: hide_site_tagline
  • Hide tagline toggle

Site Design

  • Design syles (Traditional, Modern, Trendy, Welcoming, Playful)

    • theme_mod: design_style
  • Color palette (Primary, Secondary, Tertiary, Background)

    • theme_mod: primary_color, secondary_color, tertiary_color, background_color
  • Header colors (Background, Foreground)

    • theme_mod: header_text_color, header_background_color
  • Footer colors (Background, Foreground)

    • theme_mod: footer_text_color, footer_background_color
  • Social icon

    • theme_mod: social_icon_color

Header

  • Header variations (1-7)

    • theme_mod: header_variation
  • Sticky header toggle

    • theme_mod: sticky_header

Footer

  • Footer variations (1-4)
    • theme_mod: footer_variation

Social

  • Social media links (Facebook, Twitter, Instagram, LinkedIn, Xing, Pinterest, YouTube, Spotify, GitHub, TikTok, Mastodon)
    • theme_mod: social_icon_{network}

Menus

  • Menu locations (Primary, Footer Navigation 1-3)

Site Settings

  • Page titles toggle

    • theme_mod: page_titles
  • Blog excerpt toggle

    • theme_mod: blog_excerpt
  • Copyright text

    • theme_mod: copyright

Migration from Site Design in CoBlocks Labs

Font Pairings

Ensure that the font pairings are migrated correctly.

  • Heading font, weight, size (rem)

    • theme_mod: fonts[ {font_name}_heading ]: [ {font_weight} ]
    • theme_mod: type_ratio. The rem size is calculated from the ratio and the body font size.
  • Body font, weight, size (rem)

    • theme_mod: fonts[ {font_name}_body ]: [ {font_weight} ]
    • theme_mod: font_size

Font Familes

These are the font families and weights we need to bundle with Go.

  • Anton [400]
  • Cardo [700]
  • Crimson Text [400, 400i, 700, 700i]
  • Fira Code [400, 400i, 700]
  • Heebo [400, 800]
  • IBM Plex Mono [400]
  • IBM Plex Sans [400]
  • Karla [400, 400i, 700]
  • Montserrat [400, 700]
  • Noto Sans [400, 400i, 700]
  • Nunito Sans [400, 400i, 600, 700]
  • Open Sans [400]
  • Poppins [600]
  • Quicksand [400, 600]
  • Recursive [900]
  • Roboto [400]
  • Source Code Pro [400, 700]
  • Trocchi [400, 600]
  • Vollkorn [400]
  • Work Sans [300, 700]
  • Yeseva One [400]

What to test

  • Colors, sizings, spacings, typography. There will be visual changes but if there are any obvious discrepancies, we should take a closer look and possibly fix them.

  • Migration from classic to block templates. Basically we want to test that customizations made in the classic theme's customizer are translated into the block templates and global styles of FSE. This is not setup to be automatic yet but passing the migrate url param will trigger the migration. You can switch between the master branch and this branch (full-site-editing) to test.

Reporting issues

Create an issue with the "Full Site Editing" label and assign me (the link autofills these details).

@jrtashjian jrtashjian added the [Status] Do Not Merge Issues/PRs that should not be merged (yet) label Apr 6, 2023
@jrtashjian jrtashjian self-assigned this Apr 6, 2023
index.php Outdated Show resolved Hide resolved
Comment on lines +3 to +4
"https://downloads.wordpress.org/plugin/woocommerce.latest-stable.zip",
"https://downloads.wordpress.org/plugin/create-block-theme.latest-stable.zip"
Copy link
Member

@AnthonyLedesma AnthonyLedesma May 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing here seems off. Also, please speak to why we would include create-block-theme in the .wp-env.json file. I presume this may be related to testing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The create-block-theme plugin is not just for testing but for development which is why included it. It will help anyone modifying styles and/or templates to work inside the site editor and export directly to the local directory and then commit to our repo.

composer.json Outdated Show resolved Hide resolved
Comment on lines -226 to -227
),
array(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dang. I just realized these layouts are going away. Historically the Layout Selector in CB has depended on these layouts from Go. The LS will be rather useless once GSE comes out. We should probably move these to CoBlocks, right? Otherwise, we should deprecate the control like Site Design - this time not because of compatibility but because of its value.

Copy link
Member Author

@jrtashjian jrtashjian May 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call out! We can keep these in Go and I will restore them. The layout selector could still be relevant but we can also expose these inside the patterns explorer in Core.

Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CICD Pipeline updates are looking good. 👍 ✅
A few questions posted up and tests will need to be addressed later, but looking good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Do Not Merge Issues/PRs that should not be merged (yet)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants