Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submenu hover regression introduced in 1.3.7 #611

Merged
merged 3 commits into from
Nov 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .dev/assets/shared/css/header/sub-menu.scss
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,3 @@
z-index: 9999;
}
}

.sub-menu[aria-hidden="true"] {
display: none;
opacity: 0;
visibility: hidden;
}
2 changes: 1 addition & 1 deletion .dev/tests/php/test-core.php
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ function testFontsUrlCustomizer() {
$GLOBALS['wp_customize'] = new WP_Customize_Manager();
$GLOBALS['wp_customize']->setup_theme();

$expected = 'https://fonts.googleapis.com/css?family=Crimson Text:400,400i,700,700i|Nunito Sans:400,400i,600,700|Heebo:400,800|Fira Code:400,400i,700|Montserrat:400,700|Trocchi:400,600|Noto Sans:400,400i,700|Source Code Pro:400,700|Work Sans:300,700|Karla:400,400i,700|Quicksand:400,600|Poppins:700&subset=latin,latin-ext';
$expected = 'https://fonts.googleapis.com/css?family=Crimson Text:400,400i,700,700i|Nunito Sans:400,400i,600,700|Heebo:400,800|Fira Code:400,400i,700|Montserrat:400,700|Trocchi:400,600|Noto Sans:400,400i,700|Source Code Pro:400,700|Work Sans:300,700|Karla:400,400i,700|Poppins:600|Quicksand:400,600&subset=latin,latin-ext';

$this->assertEquals( urldecode( $expected ), urldecode( Go\Core\fonts_url() ) );

Expand Down
2 changes: 2 additions & 0 deletions .dev/tests/php/test-woocommerce.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ function tearDown() {

parent::tearDown();

delete_option( 'woocommerce_shop_page_id' );

}

/**
Expand Down
1 change: 1 addition & 0 deletions comments.php
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
<div class="nav-next"><?php next_comments_link( esc_html_e( 'Newer Comments &rarr;', 'go' ) ); ?></div>
</nav>
<?php endif; ?>

<?php
/*
* If there are no comments and comments are closed, let's leave a note.
Expand Down
1 change: 0 additions & 1 deletion includes/pluggable.php
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ function go_comment( $comment, $args, $depth ) {
</div><!-- .reply -->
</article><!-- #comment-## -->
<?php
break;

endswitch; // end comment_type check.
}
Expand Down