Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submenu hover regression introduced in 1.3.7 #611

Merged
merged 3 commits into from
Nov 12, 2020

Conversation

EvanHerman
Copy link
Contributor

After transitioning over from css to scss this small bit of CSS code was included. Previously, this code existed here, but had no effect since it was invalid css. When it got copied over, and the invalid css was fixed, it caused open menus to be hidden.

@EvanHerman EvanHerman added [Type] Bug Something that is not working as expected [Priority] High This issue/pull request needs resolving before the next release [Status] Needs Review Tracking pull requests that need another set of eyes labels Nov 12, 2020
@EvanHerman EvanHerman added this to the Next Release milestone Nov 12, 2020
@EvanHerman EvanHerman self-assigned this Nov 12, 2020
@cypress
Copy link

cypress bot commented Nov 12, 2020



Test summary

14 0 0 0


Run details

Project Go
Status Passed
Commit 700aa4f
Started Nov 12, 2020 7:26 PM
Ended Nov 12, 2020 7:27 PM
Duration 00:53 💡
OS Linux Debian - 10.6
Browser Chrome 86

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to fix the menu bug on my end. LGTM.

@EvanHerman EvanHerman merged commit 85dadf5 into master Nov 12, 2020
@EvanHerman EvanHerman deleted the fix/menu-hover-regression branch November 12, 2020 19:37
@EvanHerman EvanHerman modified the milestones: Next Release, 1.3.9, 1.3.8 Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High This issue/pull request needs resolving before the next release [Status] Needs Review Tracking pull requests that need another set of eyes [Type] Bug Something that is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants