[dont merge] branch page some enhancements (-> PRs #7602 #7603 #7604)

[6543]

is part of the issue "branch view some enhancements #7454"

• all buttons on the right side should be with border
• find another way to layout the button correctly that does at least not rely on absolute positioning
• move button info into buttons
• delete table header
• move inline css to less

[codecov-io]

Codecov Report

Merging #7520 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7520      +/-   ##
==========================================
- Coverage   41.25%   41.24%   -0.02%     
==========================================
  Files         469      469              
  Lines       63618    63608      -10     
==========================================
- Hits        26246    26234      -12     
- Misses      33948    33955       +7     
+ Partials     3424     3419       -5

Impacted Files	Coverage Δ
models/unit.go	62.16% <0%> (-5.41%)	⬇️
modules/log/event.go	64.61% <0%> (-1.03%)	⬇️
models/repo_list.go	72.08% <0%> (-1.02%)	⬇️
models/ssh_key.go	46% <0%> (-0.28%)	⬇️
routers/repo/http.go	35.06% <0%> (-0.27%)	⬇️
modules/git/parse.go	58.92% <0%> (ø)	⬆️
modules/git/repo_tree.go	41.26% <0%> (ø)	⬆️
modules/git/notes.go	40% <0%> (ø)	⬆️
modules/git/tree_blob.go	82.92% <0%> (ø)	⬆️
routers/api/v1/api.go	71.36% <0%> (ø)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcbc9f3...99470a8. Read the comment docs.

[lunny]

duplicated protect button.

[gary-kim]

duplicated protect button.

That's not from this PR. I added the icon on the left so users without write access can also see if the branch is protected.
Maybe instead of the protected icon, we should just get rid of the delete branch button if the branch is protected?

[6543]

@gary-kim done ... ?

[gary-kim]

It seems to have broken for me. Using Firefox 67.

[6543]

@gary-kim WIP

[6543]

@gary-kim test it now :D

[6543]

duplicated protect button.

That's not from this PR. I added the icon on the left so users without write access can also see if the branch is protected.
Maybe instead of the protected icon, we should just get rid of the delete branch button if the branch is protected?

i moved the protect symbol to the delete colum, all symbols are in one row. if this is ok, we should rename the colum header (to actions?) or delete the table header because it isn't very usefull at all

[6543]

I like how the download button looks now. There still seems to be a few things to be fixed up though.

Also, in your image, it seems like the right border of the New Pull Request button is cut off. Is that an issue unique to the Blink engine? It doesn't seem to be happening in Firefox.

EDIT: Oh, turns out the border being cut off happens when the screen is smaller then 1200px. Once you pass the breakpoint, the button border on the right side gets cut off. That should get fixed.

saw this bug too, but thought this sint relatet tho this PR would put it into another one.

[6543]

@lafriks @gary-kim is this state now ready for a merge?
@gary-kim i think your sugesstions are new issues -> PR (#7577; #7576)

EDIT: I'll remove it from the diff so it should realy handled seperatly (99470a8)

[silverwind]

typo alinged?

[silverwind]

I think the current implementation takes away too much space from the important left-aligned column because having the buttons inside individual fixed columns introduces unnecessary spacing. I'd put all three buttons in the same td and make them look like this (remove compact class on the pull button):

Then right-align the diffstat and let the leftmost column take the remaining space.

[silverwind]

Oh, and if you want to save even more space, change the pull button to a icon-only button.

[6543]

I'll split this pull up into seperate once !

so i can focus on one thing at a time

[6543]

splitup is complete