Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Branch View] protected symbol shows up unintended when not logged in #7576

Closed
6543 opened this issue Jul 23, 2019 · 6 comments · Fixed by #7695
Closed

[Branch View] protected symbol shows up unintended when not logged in #7576

6543 opened this issue Jul 23, 2019 · 6 comments · Fixed by #7695
Labels
type/bug
Milestone
1.10.0

Comments

@6543
Copy link
Member

6543 commented Jul 23, 2019 •
edited
Loading

branches shows protected symbol if you arent signt in.

if you are loged in protected symbol is on corect places only (doesnt mather if you only have read or wirte permissions)
@6543 6543 mentioned this issue Jul 23, 2019
Closed
14 tasks
@gary-kim
Copy link
Member

gary-kim commented Jul 23, 2019 •
edited
Loading

There does seem to be a bug where the branches page will indicate that all branches are protected whether or not they are actually protected branches.

The branches page shows the correct protected statuses on branches when logged in.

@lunny lunny added the type/bug label Jul 23, 2019
@6543 6543 mentioned this issue Jul 24, 2019
Closed
5 tasks
@6543 6543 changed the title [Branch View] default branch | protected symbol [Branch View] protected symbol shows up unintended when not logged in Jul 26, 2019
This was referenced Jul 26, 2019
Closed
Merged
@6543
Copy link
Member Author

6543 commented Jul 30, 2019

i think this is a bug in the go code (server side)

@6543
Copy link
Member Author

6543 commented Jul 30, 2019 •
edited
Loading

Error Preview:

with login

login

without login

no login

@lunny
Copy link
Member

lunny commented Jul 30, 2019

This should be resolved by #7674

@techknowlogick techknowlogick added this to the 1.10.0 milestone Jul 30, 2019
@6543
Copy link
Member Author

6543 commented Jul 30, 2019 •
edited
Loading

no it is not :(
is it fixed at your test instance? @lunny
i tested master (d974c13)

@lunny
Copy link
Member

lunny commented Jul 31, 2019

@6543 right. The bug is still there when no login. @techknowlogick

@lunny lunny reopened this Jul 31, 2019
@lunny lunny mentioned this issue Aug 1, 2019
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

improve branches list performance and fix protected branch icon when no-login lunny/gitea
4 participants
@lunny @techknowlogick @6543 @gary-kim