Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to esbuild for css minify #26445

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

silverwind
Copy link
Member

Fixes #26439.

The minification result is not ideal with esbuild, but it's better than failing competely.

@silverwind silverwind added type/enhancement An improvement of existing functionality topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Aug 10, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 10, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 10, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 11, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 11, 2023
@silverwind silverwind merged commit a838901 into go-gitea:main Aug 11, 2023
23 checks passed
@GiteaBot GiteaBot added this to the 1.21.0 milestone Aug 11, 2023
@silverwind silverwind deleted the minify-fallback branch August 11, 2023 04:13
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 11, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 11, 2023
* upstream/main:
  Update upgrade documentation to add a check for deprecated configurations (go-gitea#26451)
  Fall back to esbuild for css minify (go-gitea#26445)
  Update JS dependencies (go-gitea#26449)
  Call git.InitSimple for runRepoSyncReleases (go-gitea#26396)
  Target specific OS for devcontainer base image (go-gitea#26422)
  Lock go to 1.21 on CI (go-gitea#26433)
  Always show usernames in reaction tooltips (go-gitea#26444)
  Fix incorrect redirection in new issue using references (go-gitea#26440)
  Fix the display of orgs listed in user profile (go-gitea#26424)
  minio: add missing region on client initialization (go-gitea#26412)
  Fix wrong middleware sequence (go-gitea#26428)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build error:Error: Cannot find module '../lightningcss.freebsd-x64.node'
4 participants