Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock go to 1.21 on CI #26433

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Lock go to 1.21 on CI #26433

merged 3 commits into from
Aug 10, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Aug 10, 2023

To prevent unwanted surprises with new minor versions of go, lock the version to minor version using semver tilde syntax. We were already getting 1.21.0 since yesterday, so use that version now as minimum.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 10, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 10, 2023
@silverwind silverwind added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 10, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 10, 2023
@silverwind silverwind changed the title Lock go to minor version on Actions Lock go 1.21 on Actions Aug 10, 2023
@silverwind silverwind changed the title Lock go 1.21 on Actions Lock go to 1.21 on Actions Aug 10, 2023
@silverwind silverwind changed the title Lock go to 1.21 on Actions Lock go to 1.21 on CI Aug 10, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 10, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 10, 2023
@silverwind silverwind enabled auto-merge (squash) August 10, 2023 20:59
@silverwind silverwind merged commit 1772814 into go-gitea:main Aug 10, 2023
23 checks passed
@GiteaBot GiteaBot added this to the 1.21.0 milestone Aug 10, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 10, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 11, 2023
* upstream/main:
  Update upgrade documentation to add a check for deprecated configurations (go-gitea#26451)
  Fall back to esbuild for css minify (go-gitea#26445)
  Update JS dependencies (go-gitea#26449)
  Call git.InitSimple for runRepoSyncReleases (go-gitea#26396)
  Target specific OS for devcontainer base image (go-gitea#26422)
  Lock go to 1.21 on CI (go-gitea#26433)
  Always show usernames in reaction tooltips (go-gitea#26444)
  Fix incorrect redirection in new issue using references (go-gitea#26440)
  Fix the display of orgs listed in user profile (go-gitea#26424)
  minio: add missing region on client initialization (go-gitea#26412)
  Fix wrong middleware sequence (go-gitea#26428)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants