Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getting the tag list does not require being signed in #24413

Merged
merged 2 commits into from
Apr 29, 2023
Merged

getting the tag list does not require being signed in #24413

merged 2 commits into from
Apr 29, 2023

Conversation

earl-warren
Copy link
Contributor

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 28, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2023
@silverwind
Copy link
Member

Regressed by #23465 it seems.

@silverwind silverwind added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Apr 28, 2023
@lunny lunny requested a review from Zettat123 April 29, 2023 00:42
wxiaoguang
wxiaoguang approved these changes Apr 29, 2023
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a quick fix it looks good.

There are still some mistakes in old code when using xxxSignIn, I will fix them in next PR.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 29, 2023
@wxiaoguang wxiaoguang mentioned this pull request Apr 29, 2023
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 29, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 29, 2023
@lunny lunny enabled auto-merge (squash) April 29, 2023 04:16
@lunny lunny merged commit 9cf721e into go-gitea:main Apr 29, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone Apr 29, 2023
@GiteaBot GiteaBot mentioned this pull request Apr 29, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 29, 2023
@earl-warren @GiteaBot
getting the tag list does not require being signed in (go-gitea#24413)
e7e56aa 
Fixes: https://codeberg.org/forgejo/forgejo/issues/681
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 29, 2023
silverwind pushed a commit that referenced this pull request Apr 29, 2023
@GiteaBot @earl-warren
getting the tag list does not require being signed in (#24413) (#24416)
e76b3f7 
Backport #24413 by @earl-warren

Fixes: https://codeberg.org/forgejo/forgejo/issues/681

Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com>
silverwind pushed a commit that referenced this pull request May 4, 2023
@wxiaoguang @GiteaBot
Fix some mistakes when using ignSignIn (#24415)
03fab6a 
Some old code doesn't respect the definition of `RequireSignInView` (the
`ignSignIn` is forgotten).

After #24413, this PR will do more fixes, ~~and rename the strange
`ignSignIn` to `optSignIn`.~~

This PR is ready for review, I think we can postpone the "ignSignIn"
renaming to another, to make this PR simple and clear.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
Sh4kE added a commit to Sh4kE/k8s-projects that referenced this pull request May 7, 2023
@Sh4kE
Update gitea/gitea Docker tag to v1.19.3 (#178)
972b4b3 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [gitea/gitea](https://github.com/go-gitea/gitea) | patch | `1.19.2-rootless` -> `1.19.3-rootless` |

---

### Release Notes

<details>
<summary>go-gitea/gitea</summary>

### [`v1.19.3`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#&#8203;1193-httpsgithubcomgo-giteagiteareleasestag1193---2023-05-03)

[Compare Source](go-gitea/gitea@v1.19.2...v1.19.3)

-   SECURITY
    -   Use golang 1.20.4 to fix CVE-2023-24539, CVE-2023-24540, and CVE-2023-29400
-   ENHANCEMENTS
    -   Enable whitespace rendering on selection in Monaco ([#&#8203;24444](go-gitea/gitea#24444)) ([#&#8203;24485](go-gitea/gitea#24485))
    -   Improve milestone filter on issues page ([#&#8203;22423](go-gitea/gitea#22423)) ([#&#8203;24440](go-gitea/gitea#24440))
-   BUGFIXES
    -   Fix api error message if fork exists ([#&#8203;24487](go-gitea/gitea#24487)) ([#&#8203;24493](go-gitea/gitea#24493))
    -   Fix user-cards format ([#&#8203;24428](go-gitea/gitea#24428)) ([#&#8203;24431](go-gitea/gitea#24431))
    -   Fix incorrect CurrentUser check for docker rootless ([#&#8203;24435](go-gitea/gitea#24435))
    -   Getting the tag list does not require being signed in ([#&#8203;24413](go-gitea/gitea#24413)) ([#&#8203;24416](go-gitea/gitea#24416))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42Ni4zIiwidXBkYXRlZEluVmVyIjoiMzUuNjYuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: Michael Wittig <michael.wittig@posteo.de>
Reviewed-on: https://gitea.sh4ke.rocks/sh4ke/k8s-projects/pulls/178
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@jolheiser jolheiser jolheiser approved these changes

@Zettat123 Zettat123 Awaiting requested review from Zettat123

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
6 participants
@earl-warren @silverwind @wxiaoguang @jolheiser @lunny @GiteaBot