Improve milestone filter on issues page #22423

lunny · 2023-01-13T05:21:15Z

Now we have All milestones, No milestones, Open milestones and Closed milestones.
Fix #11924
Fix #22411

codecov-commenter · 2023-01-13T05:59:48Z

Codecov Report

Merging #22423 (b13c0ed) into main (f521e88) will decrease coverage by 0.15%.
The diff coverage is 32.40%.

❗ Current head b13c0ed differs from pull request most recent head 3700af0. Consider uploading reports for the commit 3700af0 to get more accurate results

@@            Coverage Diff             @@
##             main   #22423      +/-   ##
==========================================
- Coverage   47.14%   46.99%   -0.15%     
==========================================
  Files        1149     1163      +14     
  Lines      151446   153767    +2321     
==========================================
+ Hits        71397    72265     +868     
- Misses      71611    72985    +1374     
- Partials     8438     8517      +79

Impacted Files	Coverage Δ
cmd/dump.go	`0.66% <0.00%> (-0.01%)`	⬇️
cmd/mailer.go	`0.00% <0.00%> (ø)`
cmd/manager.go	`0.00% <0.00%> (ø)`
cmd/manager_logging.go	`0.00% <0.00%> (ø)`
cmd/migrate_storage.go	`5.76% <0.00%> (-0.12%)`	⬇️
cmd/restore_repo.go	`0.00% <0.00%> (ø)`
cmd/web.go	`0.00% <0.00%> (ø)`
models/actions/run.go	`1.63% <0.00%> (-0.10%)`	⬇️
models/actions/runner.go	`1.44% <ø> (ø)`
models/db/search.go	`100.00% <ø> (ø)`
... and 63 more

... and 122 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jolheiser

Just a minor nit if we're going to change the translation keys anyways.

options/locale/locale_en-US.ini

templates/repo/issue/list.tmpl

routers/web/repo/issue.go

templates/repo/issue/list.tmpl

models/issues/issue.go

templates/repo/issue/list.tmpl

lunny · 2023-01-29T07:05:17Z

@delvh @jolheiser done.

delvh · 2023-01-30T13:56:11Z

The other filters (project, label, …) don't have this yet, right?
They will get it in a later PR?

lunny · 2023-01-30T16:28:32Z

The other filters (project, label, …) don't have this yet, right? They will get it in a later PR?

I think there is already a PR for project, for label we can have another PR.

delvh · 2023-01-30T16:44:17Z

No, the project PR simply added the filter in the first place and omitted the No project and All projects filters.

lunny · 2023-01-31T02:31:35Z

No, the project PR simply added the filter in the first place and omitted the No project and All projects filters.

I mean #22640

models/issues/issue.go

…lunny/milestone_filter

wxiaoguang · 2023-04-10T11:02:53Z

models/issues/issue.go

+	if len(opts.MilestoneIDs) == 1 && opts.MilestoneIDs[0] == db.NoConditionID {
+		sess.And("issue.milestone_id = 0")


The name NoConditionID looks really strange. When reading the code:

The parameter is no-condition-ID

The the next line adds a condition .....

Just a nit, just my opinion, not blocker.

Now we have `All milestones`, `No milestones`, `Open milestones` and `Closed milestones`. Fix go-gitea#11924 Fix go-gitea#22411 <img width="1166" alt="image" src="https://user-images.githubusercontent.com/81045/212243375-95eea035-a972-44b8-8088-53db614cb07e.png">

@lunny

Backport #22423 by @lunny Now we have `All milestones`, `No milestones`, `Open milestones` and `Closed milestones`. Fix #11924 Fix #22411 <img width="1166" alt="image" src="https://user-images.githubusercontent.com/81045/212243375-95eea035-a972-44b8-8088-53db614cb07e.png"> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [gitea/gitea](https://github.com/go-gitea/gitea) | patch | `1.19.2-rootless` -> `1.19.3-rootless` | --- ### Release Notes <details> <summary>go-gitea/gitea</summary> ### [`v1.19.3`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1193-httpsgithubcomgo-giteagiteareleasestag1193---2023-05-03) [Compare Source](go-gitea/gitea@v1.19.2...v1.19.3) - SECURITY - Use golang 1.20.4 to fix CVE-2023-24539, CVE-2023-24540, and CVE-2023-29400 - ENHANCEMENTS - Enable whitespace rendering on selection in Monaco ([#24444](go-gitea/gitea#24444)) ([#24485](go-gitea/gitea#24485)) - Improve milestone filter on issues page ([#22423](go-gitea/gitea#22423)) ([#24440](go-gitea/gitea#24440)) - BUGFIXES - Fix api error message if fork exists ([#24487](go-gitea/gitea#24487)) ([#24493](go-gitea/gitea#24493)) - Fix user-cards format ([#24428](go-gitea/gitea#24428)) ([#24431](go-gitea/gitea#24431)) - Fix incorrect CurrentUser check for docker rootless ([#24435](go-gitea/gitea#24435)) - Getting the tag list does not require being signed in ([#24413](go-gitea/gitea#24413)) ([#24416](go-gitea/gitea#24416)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: Michael Wittig <michael.wittig@posteo.de> Reviewed-on: https://gitea.sh4ke.rocks/sh4ke/k8s-projects/pulls/178

Improve milestone filter on issues page

0cb8dbb

lunny added the type/enhancement An improvement of existing functionality label Jan 13, 2023

lunny added this to the 1.19.0 milestone Jan 13, 2023

selected

4da0d94

lunny requested review from delvh and 6543 January 13, 2023 05:53

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 13, 2023

jolheiser reviewed Jan 16, 2023

View reviewed changes

options/locale/locale_en-US.ini Outdated Show resolved Hide resolved

templates/repo/issue/list.tmpl Outdated Show resolved Hide resolved

delvh reviewed Jan 19, 2023

View reviewed changes

lunny added 4 commits January 29, 2023 11:37

follow @delvh suggestion

ae769b2

Merge branch 'main' into lunny/milestone_filter

91844b3

follow @delvh suggestion

b663d4d

merge main branch

5c8fab3

lunny added type/bug outdated/backport/v1.18 This PR should be backported to Gitea 1.18 labels Jan 30, 2023

delvh mentioned this pull request Feb 1, 2023

Show all projects, not just repo projects and open/closed projects #22640

Merged

merge main branch

664fbd1

yardenshoham modified the milestones: 1.19.0, 1.20.0 Feb 22, 2023

yardenshoham added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Feb 22, 2023

6543 and others added 2 commits March 5, 2023 15:06

Merge branch 'main' into lunny/milestone_filter

4bf7da9

Merge branch 'main' into lunny/milestone_filter

ec4f7ba

wxiaoguang reviewed Mar 25, 2023

View reviewed changes

models/issues/issue.go Outdated Show resolved Hide resolved

wxiaoguang reviewed Mar 25, 2023

View reviewed changes

models/issues/issue.go Outdated Show resolved Hide resolved

lunny added 7 commits April 10, 2023 18:29

Use new name NoConditionID

c971e6b

Merge branch 'main' into lunny/milestone_filter

6c69879

Update item classes

56970a6

Merge branch 'lunny/milestone_filter' of github.com:lunny/gitea into …

6bcf381

…lunny/milestone_filter

Update milestone filter class

72d7457

Add divider

13a6861

Merge branch 'main' into lunny/milestone_filter

b13c0ed

wxiaoguang reviewed Apr 10, 2023

View reviewed changes

lunny removed the outdated/backport/v1.18 This PR should be backported to Gitea 1.18 label Apr 10, 2023

wolfogre approved these changes Apr 10, 2023

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 10, 2023

Merge branch 'main' into lunny/milestone_filter

3700af0

6543 approved these changes Apr 30, 2023

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 30, 2023

6543 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 30, 2023

Merge branch 'main' into lunny/milestone_filter

21aab11

pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 30, 2023

6543 enabled auto-merge (squash) April 30, 2023 12:30

6543 merged commit 3f0651d into go-gitea:main Apr 30, 2023

GiteaBot mentioned this pull request Apr 30, 2023

Improve milestone filter on issues page (#22423) #24440

Merged

GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 30, 2023

lunny deleted the lunny/milestone_filter branch April 30, 2023 13:18

go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve milestone filter on issues page #22423

Improve milestone filter on issues page #22423

lunny commented Jan 13, 2023 •

edited

Loading

codecov-commenter commented Jan 13, 2023 •

edited

Loading

jolheiser left a comment

lunny commented Jan 29, 2023

delvh commented Jan 30, 2023

lunny commented Jan 30, 2023

delvh commented Jan 30, 2023

lunny commented Jan 31, 2023

wxiaoguang Apr 10, 2023

		if len(opts.MilestoneIDs) == 1 && opts.MilestoneIDs[0] == db.NoConditionID {
		sess.And("issue.milestone_id = 0")

Improve milestone filter on issues page #22423

Improve milestone filter on issues page #22423

Conversation

lunny commented Jan 13, 2023 • edited Loading

codecov-commenter commented Jan 13, 2023 • edited Loading

Codecov Report

jolheiser left a comment

Choose a reason for hiding this comment

lunny commented Jan 29, 2023

delvh commented Jan 30, 2023

lunny commented Jan 30, 2023

delvh commented Jan 30, 2023

lunny commented Jan 31, 2023

wxiaoguang Apr 10, 2023

Choose a reason for hiding this comment

lunny commented Jan 13, 2023 •

edited

Loading

codecov-commenter commented Jan 13, 2023 •

edited

Loading