Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent panic in notify issue change content #23019

Conversation

zeripath
Copy link
Contributor

Ensure that issue pullrequests are loaded before trying to set the self-reference.

Ensure that issue pullrequests are loaded before trying to set the self-reference.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug outdated/backport/v1.18 This PR should be backported to Gitea 1.18 labels Feb 20, 2023
@zeripath zeripath added this to the 1.19.0 milestone Feb 20, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 20, 2023
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand the changes in this PR:

  1. Why was the indentation in LoadPullRequest increased? It doesn't change any logic…
  2. Why were the two unrelated lines in services/webhook/notifier.go removed?

services/webhook/notifier.go Show resolved Hide resolved
services/webhook/notifier.go Show resolved Hide resolved
@KN4CK3R
Copy link
Member

KN4CK3R commented Feb 20, 2023 via email

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 20, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 20, 2023
@techknowlogick techknowlogick merged commit 35d2fa7 into go-gitea:main Feb 21, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 21, 2023
@lunny
Copy link
Member

lunny commented Feb 21, 2023

Please send backport

zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 21, 2023
* upstream/main: (23 commits)
  add margin top to the top of branches (go-gitea#23002)
  Add me to maintainers (go-gitea#23026)
  Render access log template as text instead of HTML (go-gitea#23013)
  Use `gt-relative` class instead of the ambiguous `gt-pr` class  (go-gitea#23008)
  Fix intermittent panic in notify issue change content (go-gitea#23019)
  Improve pull_request_template.md (go-gitea#22888)
  Hide 2FA status from other members in organization members list (go-gitea#22999)
  handle deprecated settings (go-gitea#22992)
  Add scopes to API to create token and display them (go-gitea#22989)
  Remove unnecessary and incorrect `find('.menu').toggle()` (go-gitea#22987)
  Improve issues.LoadProject (go-gitea#22982)
  Add 1.18.4 changelog (go-gitea#22991) (go-gitea#22995)
  Fix pull request branch selector visible without clicking Edit (go-gitea#23012)
  Bump golang.org/x/net from 0.4.0 to 0.7.0 (go-gitea#22980)
  Fix panic when call api (/repos/{owner}/{repo}/pulls/{index}/files) (go-gitea#22921)
  only trigger docs build and publish when docs changed (go-gitea#22968)
  Get rules by id when editing branch protection rule (go-gitea#22932)
  Fix hidden commit status on multiple checks (go-gitea#22889)
  Add me to maintainers (go-gitea#22998)
  Add all units to the units permission list in org team members sidebar (go-gitea#22971)
  ...
@yardenshoham
Copy link
Member

Please send backport

@GiteaBot
Copy link
Contributor

GiteaBot commented Mar 9, 2023

I was unable to create a backport for 1.18, please send one manually. 🍵

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Mar 9, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@zeripath zeripath deleted the fix-intermittent-panic-notify-issue-change-content branch May 10, 2023 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.18 This PR should be backported to Gitea 1.18 type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants