add margin top to the top of branches #23002
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
GiteaBot
added
the
lgtm/need 2
|
@delvh that's true, thanks for reviewing. Changed list.tmpl and use helper.less to add margin top instead, please review again. |
GiteaBot
added
lgtm/need 1
| @@ -5,7 +5,7 @@ | |||
| {{template "base/alert" .}} | |||
| {{template "repo/sub_menu" .}} | |||
| {{if .DefaultBranchBranch}} | |||
| <h4 class="ui top attached header"> | |||
| <h4 class="ui top attached header gt-mt-4"> | |||
There was a problem hiding this comment.
I would suppose you still need another change (line 46)
The logic is:
{{if DefaultBranchBranch}}
<h4 class="ui top attached header gt-mt-4"></h4>
...
{{end}}
{{if gt (len .Branches) 1}}
<h4 class="ui top attached header /* HERE */"></h4>
...
{{end}}
There was a problem hiding this comment.
Or maybe the " top attached " just means that there is no padding/margin before .... so if you look into details, you may find more clues .....
Update: The Fomantic UI document https://fomantic-ui.com/elements/header.html#attached
There was a problem hiding this comment.
I would suppose you still need another change (line 46)
The logic is:
{{if DefaultBranchBranch}} <h4 class="ui top attached header gt-mt-4"></h4> ... {{end}} {{if gt (len .Branches) 1}} <h4 class="ui top attached header /* HERE */"></h4> ... {{end}}
For the line46, it actually already had margin top, as shown below:
It matches the following rule defined in _base.less
.ui.attached.segment ~ .ui.top.attached.header {
margin-top: 1rem;
}
Or is it something other than margin-top that needs to be changed?
Checked the document, i think the original intention of attached header does mean that it is an attached header to other, but here we might not delete attach, because it is used in many selectors.
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
LG-TM bot |
lunny
removed
the
reviewed/wait-merge
* upstream/main: (23 commits) add margin top to the top of branches (go-gitea#23002) Add me to maintainers (go-gitea#23026) Render access log template as text instead of HTML (go-gitea#23013) Use `gt-relative` class instead of the ambiguous `gt-pr` class (go-gitea#23008) Fix intermittent panic in notify issue change content (go-gitea#23019) Improve pull_request_template.md (go-gitea#22888) Hide 2FA status from other members in organization members list (go-gitea#22999) handle deprecated settings (go-gitea#22992) Add scopes to API to create token and display them (go-gitea#22989) Remove unnecessary and incorrect `find('.menu').toggle()` (go-gitea#22987) Improve issues.LoadProject (go-gitea#22982) Add 1.18.4 changelog (go-gitea#22991) (go-gitea#22995) Fix pull request branch selector visible without clicking Edit (go-gitea#23012) Bump golang.org/x/net from 0.4.0 to 0.7.0 (go-gitea#22980) Fix panic when call api (/repos/{owner}/{repo}/pulls/{index}/files) (go-gitea#22921) only trigger docs build and publish when docs changed (go-gitea#22968) Get rules by id when editing branch protection rule (go-gitea#22932) Fix hidden commit status on multiple checks (go-gitea#22889) Add me to maintainers (go-gitea#22998) Add all units to the units permission list in org team members sidebar (go-gitea#22971) ...
add margin top as mentioned in #22973