Fix nil error when some pages are rendered outside request context #19427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
approved these changes
Apr 19, 2022
GiteaBot
added
the
lgtm/need 1
wxiaoguang
added
the
skip-changelog
zeripath
approved these changes
Apr 19, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 20, 2022
* giteaofficial/main: When dumping trim the standard suffices instead of a random suffix (go-gitea#19440) Add uploadpack.allowAnySHA1InWant to allow --filter=blob:none with older git clients (go-gitea#19430) Don't allow merging PR's which are being conflict checked (go-gitea#19357) doc: add brief intro on using traefik as reverse-proxy (go-gitea#19432) Fix panic in team repos API (go-gitea#19431) When updating mirror repo intervals by API reschedule next update too (go-gitea#19429) Fix nil error when some pages are rendered outside request context (go-gitea#19427) Add Helm Chart registry (go-gitea#19406)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #19426
This PR is only a quick (dirty) fix. The root problem is that
sspi_windows.gois not well designed, it shouldn't do template rendering in a service package, these code was just a copy&paste and should be refactored later.