Error 500 on SPNEGO with SSPI authentication (TmplLoadTimes)

[tsparber-meds]

Description

If the login type SPNEGO with SSPI is enabled the following Error 500 is returned upon login.

template: base/footer_content:4:257: executing "base/footer_content" at
<call .TmplLoadTimes>: error calling call: call of nil`.

The issue seems to come from #17979 as this removes the TmplLoadTimes function from modules/templates/base.go.

The verify function just uses the base vars and thus the function is missing.

gitea/services/auth/sspi_windows.go

Line 112 in b74322d

err := s.rnd.HTML(w, http.StatusUnauthorized, string(tplSignIn), templates.BaseVars().Merge(store.GetData()))

Disabling the footer load times via app.ini, does allow the login wia SPNEGO.

[other]
SHOW_FOOTER_TEMPLATE_LOAD_TIME = false

Gitea Version

1.16.5

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

Git Version

2.35.1.windows.2

Operating System

Windows Server 2019

How are you running Gitea?

Running from Command-Line downloaded from gitea.io

Database

SQLite

[wxiaoguang]

Fix is coming

• Fix nil error when some pages are rendered outside request context #19427
• Backport: Fix nil error when some pages are rendered outside request context (#19427) #19428