Update assignees check to include any writing team and change org sidebar #18680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#18572 Signed-off-by: Andrew Thornton <art27@cantab.net>
Fix go-gitea#18572 Signed-off-by: Andrew Thornton <art27@cantab.net>
Gusted
reviewed
Feb 9, 2022
GiteaBot
added
lgtm/need 2
zeripath
commented
Feb 9, 2022
lunny
reviewed
Feb 14, 2022
lunny
reviewed
Feb 21, 2022
lunny
approved these changes
Feb 22, 2022
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Feb 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #18680 +/- ##
=======================================
Coverage ? 46.60%
=======================================
Files ? 853
Lines ? 122492
Branches ? 0
=======================================
Hits ? 57085
Misses ? 58515
Partials ? 6892
Continue to review full report at Codecov.
|
Gusted
reviewed
Feb 23, 2022
Signed-off-by: Andrew Thornton <art27@cantab.net>
Gusted
approved these changes
Feb 23, 2022
GiteaBot
added
lgtm/done
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 23, 2022
…ebar (go-gitea#18680) Backport go-gitea#18680 Following the merging of go-gitea#17811 teams can now have differing write and readonly permissions, however the assignee list will not include teams which have mixed perms. Further the org sidebar is no longer helpful as it can't describe these mixed permissions situations. Fix go-gitea#18572 Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
pushed a commit
that referenced
this pull request
Feb 24, 2022
…ebar (#18680) (#18873) Backport #18680 Following the merging of #17811 teams can now have differing write and readonly permissions, however the assignee list will not include teams which have mixed perms. Further the org sidebar is no longer helpful as it can't describe these mixed permissions situations. Fix #18572 Signed-off-by: Andrew Thornton <art27@cantab.net>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 24, 2022
* giteaofficial/main: Fix ldap user sync missed email in email_address table (go-gitea#18786) Update assignees check to include any writing team and change org sidebar (go-gitea#18680) Set max text height to prevent overflow (go-gitea#18862) Lock gofumpt to v0.3.0 and run it (go-gitea#18866)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…ebar (go-gitea#18680) Following the merging of go-gitea#17811 teams can now have differing write and readonly permissions, however the assignee list will not include teams which have mixed perms. Further the org sidebar is no longer helpful as it can't describe these mixed permissions situations. Fix go-gitea#18572 Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the merging of #17811 teams can now have differing write and readonly permissions, however the assignee list will not include teams which have mixed perms.
Further the org sidebar is no longer helpful as it can't describe these mixed permissions situations.
Fix #18572