Hook hs-minor-mode into verilog-mode

[abradd]

Add hook to verilog-mode for hs-minor-mode.

verilog-ts-mode loads verilog-mode so it seemed sensible to hook into verilog-mode.

ERT tests are failing on what seems like the absence of a treesitter dependency, but they fail before and after the patch so it likely unrelated.

[gmlarumbe]

Hi @abradd ,

Thanks a lot for the PR! Much appreciated :)

Just a couple of minor things before merging:

verilog-ts-mode loads verilog-mode so it seemed sensible to hook into verilog-mode.

You are right, and for the time being that would be the simplest way of setting it up. However I would suggest adding the hook also to verilog-ts-mode since at some point it might not be derived from verilog-mode anymore but from a verilog-base-mode similar to how it is being done for other programming languages such as C/Python.

Finally, there is a minor issue when lazy loading the package with use-package and setting it up with verilog-ext-mode-setup in the :config section. In this case the first time a Verilog buffer is opened hs-minor-mode will still be disabled. There is a simple workaround that is also used for font-lock.

Could you try if everything still works well for you after applying this patch?

diff --git a/verilog-ext-hs.el b/verilog-ext-hs.el
index 855a20b..ef505b4 100644
--- a/verilog-ext-hs.el
+++ b/verilog-ext-hs.el
@@ -70,7 +70,12 @@
                                            ,verilog-ext-hs-block-end-keywords-re
                                            nil
                                            ,(cdr mode))))
-  (add-hook 'verilog-mode-hook 'hs-minor-mode))
+  (dolist (hook '(verilog-mode-hook verilog-ts-mode-hook))
+    (add-hook hook #'hs-minor-mode))
+  ;; Workaround to enable `hideshow' on first file visit with lazy loading using
+  ;; :config section with `use-package'
+  (when (member major-mode '(verilog-mode verilog-ts-mode))
+    (hs-minor-mode 1)))
 
 (defun verilog-ext-hs-toggle-hiding (&optional e)
   "Wrapper for `hs-toggle-hiding' depending on current Verilog `major-mode'.

Thanks a lot!

[abradd]

You are right, and for the time being that would be the simplest way of setting it up. However I would suggest adding the hook also to verilog-ts-mode since at some point it might not be derived from verilog-mode anymore but from a verilog-base-mode similar to how it is being done for other programming languages such as C/Python.

I was not aware of this, thanks.

Finally, there is a minor issue when lazy loading the package with use-package and setting it up with verilog-ext-mode-setup in the :config section. In this case the first time a Verilog buffer is opened hs-minor-mode will still be disabled. There is a simple workaround that is also used for font-lock.

Did not realize this, thanks.

Could you try if everything still works well for you after applying this patch?

I tested this and it works. I've added the patch to this pull request.

…

--